From cf9b0a2d4813c16cfdc60ca965f0b16eb1e30178 Mon Sep 17 00:00:00 2001 From: Ethan de Wit <150452728+Nozzit@users.noreply.github.com> Date: Sat, 21 Nov 2026 17:25:57 +0100 Subject: [PATCH 1/2] fix(acp-registry): Mistral Vibe runs a renamed model under its old ID Vibe keeps a renamed model's old ID as a catalog alias and resolves it in session/set_config_option, refusing an unknown model with invalid params. T3 refused the alias locally because Vibe's model option no longer lists it, so a remembered pick failed every turn. A flavor flag now lets Vibe judge an unlisted explicit model; other agents keep the local check. Fixes #40416 Co-Authored-By: Claude Opus 5.5 --- .../Adapters/AcpRegistryAdapterV2.test.ts | 46 +++++++++++++++++++ .../src/server/adapter.ts | 6 ++- packages/provider-acp/src/server/adapter.ts | 22 ++++++--- 3 files changed, 67 insertions(+), 7 deletions(-) diff --git a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts index 55b313a9d3ad..e9ca8118cf9d 100644 --- a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts +++ b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts @@ -1165,6 +1165,52 @@ describe("AcpRegistryAdapterV2", () => { }, ); + // Mistral Vibe 3.1 keeps a renamed model's old ID as a catalog alias and + // resolves it in session/set_config_option, so the agent judges a stored + // name it no longer lists. + it.effect.each([ + { name: "resolves", stored: "mistral-large-4-0-3", resolvedTo: "mistral-large-4-0" }, + { name: "rejects", stored: "missing", resolvedTo: undefined }, + ] as const)("lets Mistral Vibe judge an unlisted stored model: $name", (testCase) => { + const vibeModel = (currentValue: string) => ({ + ...modelOption("model", currentValue), + options: ["mistral-large-4-0", "mistral-medium-latest"].map((value) => ({ + value, + name: value, + })), + }); + return Effect.gen(function* () { + const { configurations } = yield* openWithStoredPicks({ + agentId: "mistral-vibe", + setup: { configOptions: [vibeModel("mistral-medium-latest")] }, + storedModel: testCase.stored, + ...(testCase.resolvedTo === undefined ? { rejectedModel: testCase.stored } : {}), + pickFrames: [ + outbound("session/set_config_option", { + sessionId: "agent-session", + configId: "model", + value: testCase.stored, + }), + testCase.resolvedTo === undefined + ? { + type: "emit_inbound", + frame: { + kind: "response", + method: "session/set_config_option", + error: { code: -32602, message: `Unknown model: ${testCase.stored}` }, + }, + } + : answer("session/set_config_option", { + configOptions: [vibeModel(testCase.resolvedTo)], + }), + ], + }); + if (testCase.resolvedTo !== undefined) { + assert.equal(configurations[0]?.currentModelId, testCase.resolvedTo); + } + }).pipe(Effect.provide(layerTest)); + }); + // regression: #19519 models come from session model state, not a hardcoded list it.effect("keeps unadvertised default and auto selections agent-controlled", () => Effect.gen(function* () { diff --git a/packages/provider-acp-registry/src/server/adapter.ts b/packages/provider-acp-registry/src/server/adapter.ts index 8eb5dbb30b8c..4c476971f0b3 100644 --- a/packages/provider-acp-registry/src/server/adapter.ts +++ b/packages/provider-acp-registry/src/server/adapter.ts @@ -299,7 +299,11 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu ), ), }), - ...(isVibe ? { registerExtensions: registerMistralVibeAcpExtensions } : {}), + // Vibe (v3.1.4) resolves the old ID it keeps as an alias after a model rename and refuses an + // unknown model with invalid params. + ...(isVibe + ? { registerExtensions: registerMistralVibeAcpExtensions, resolvesUnlistedModels: true } + : {}), ...(isClaude ? { followAgentWorkState: true, diff --git a/packages/provider-acp/src/server/adapter.ts b/packages/provider-acp/src/server/adapter.ts index a712d40629e6..aebbaba6bee0 100644 --- a/packages/provider-acp/src/server/adapter.ts +++ b/packages/provider-acp/src/server/adapter.ts @@ -456,6 +456,12 @@ export interface AcpAdapterV2Flavor { ChildProcessSpawner.ChildProcessSpawner | SecureRandom.SecureRandom | Scope.Scope >; readonly customModels?: ReadonlyArray; + /** + * The agent resolves a model its model option does not list, such as the old ID it keeps as an + * alias after a rename, and refuses an unknown one with invalid params. An unlisted explicit + * model is then written for the agent to judge, and the session runs the model it reports. + */ + readonly resolvesUnlistedModels?: boolean; /** The agent may run another model than session/new reports, so the model is always written. */ readonly alwaysSetModel?: boolean; /** Values the client shows for options a new session's selection leaves unset. */ @@ -8070,6 +8076,7 @@ export const makeAcpAdapterV2 = Effect.fn("makeAcpAdapterV2")(function* ( ) return; const option = findModelConfigOption(yield* runtime.getConfigOptions); + if (option !== undefined && flavor.resolvesUnlistedModels === true) return; const models = (yield* Ref.get(activeSessionSetup))?.sessionSetupResult.models; const available = option?.type === "select" @@ -8118,18 +8125,21 @@ export const makeAcpAdapterV2 = Effect.fn("makeAcpAdapterV2")(function* ( const modelOption = findModelConfigOption(yield* runtime.getConfigOptions); const modelState = startResult.sessionSetupResult.models; if (modelOption?.type === "select") { - if ( - isCustomModel || - flattenSelectChoices(modelOption.options).some( - (choice) => choice.value === requestedModel, - ) - ) { + const isListed = flattenSelectChoices(modelOption.options).some( + (choice) => choice.value === requestedModel, + ); + if (isCustomModel || isListed) { yield* runtime .setConfigOption(modelOption.id, requestedModel, { resendCurrentValue: flavor.alwaysSetModel === true, }) .pipe(Effect.mapError(rejectedModel)); appliedModel = requestedModel; + } else if (flavor.resolvesUnlistedModels === true) { + // The model option's current value then names the model the agent resolved. + yield* runtime + .setConfigOption(modelOption.id, requestedModel, { allowUnlistedValue: true }) + .pipe(Effect.mapError(rejectedModel)); } } else if ( modelState != null && From a6b3b4f21c149b98de3e71780123b5d73dcd6673 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Sat, 21 Nov 2026 16:41:11 +0000 Subject: [PATCH 2/2] fix(acp-registry): Vibe keeps its own default for default and auto selections Co-Authored-By: Claude Opus 5.5 --- .../Adapters/AcpRegistryAdapterV2.test.ts | 42 ++++++++++--------- packages/provider-acp/src/server/adapter.ts | 6 ++- 2 files changed, 28 insertions(+), 20 deletions(-) diff --git a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts index e9ca8118cf9d..673b84592a54 100644 --- a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts +++ b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts @@ -1171,6 +1171,7 @@ describe("AcpRegistryAdapterV2", () => { it.effect.each([ { name: "resolves", stored: "mistral-large-4-0-3", resolvedTo: "mistral-large-4-0" }, { name: "rejects", stored: "missing", resolvedTo: undefined }, + { name: "keeps default", stored: "default", resolvedTo: "mistral-medium-latest" }, ] as const)("lets Mistral Vibe judge an unlisted stored model: $name", (testCase) => { const vibeModel = (currentValue: string) => ({ ...modelOption("model", currentValue), @@ -1185,25 +1186,28 @@ describe("AcpRegistryAdapterV2", () => { setup: { configOptions: [vibeModel("mistral-medium-latest")] }, storedModel: testCase.stored, ...(testCase.resolvedTo === undefined ? { rejectedModel: testCase.stored } : {}), - pickFrames: [ - outbound("session/set_config_option", { - sessionId: "agent-session", - configId: "model", - value: testCase.stored, - }), - testCase.resolvedTo === undefined - ? { - type: "emit_inbound", - frame: { - kind: "response", - method: "session/set_config_option", - error: { code: -32602, message: `Unknown model: ${testCase.stored}` }, - }, - } - : answer("session/set_config_option", { - configOptions: [vibeModel(testCase.resolvedTo)], - }), - ], + pickFrames: + testCase.stored === "default" + ? [] + : [ + outbound("session/set_config_option", { + sessionId: "agent-session", + configId: "model", + value: testCase.stored, + }), + testCase.resolvedTo === undefined + ? { + type: "emit_inbound", + frame: { + kind: "response", + method: "session/set_config_option", + error: { code: -32602, message: `Unknown model: ${testCase.stored}` }, + }, + } + : answer("session/set_config_option", { + configOptions: [vibeModel(testCase.resolvedTo)], + }), + ], }); if (testCase.resolvedTo !== undefined) { assert.equal(configurations[0]?.currentModelId, testCase.resolvedTo); diff --git a/packages/provider-acp/src/server/adapter.ts b/packages/provider-acp/src/server/adapter.ts index aebbaba6bee0..dc42a2f3e66c 100644 --- a/packages/provider-acp/src/server/adapter.ts +++ b/packages/provider-acp/src/server/adapter.ts @@ -8135,7 +8135,11 @@ export const makeAcpAdapterV2 = Effect.fn("makeAcpAdapterV2")(function* ( }) .pipe(Effect.mapError(rejectedModel)); appliedModel = requestedModel; - } else if (flavor.resolvesUnlistedModels === true) { + } else if ( + flavor.resolvesUnlistedModels === true && + requestedModel !== "default" && + requestedModel !== "auto" + ) { // The model option's current value then names the model the agent resolved. yield* runtime .setConfigOption(modelOption.id, requestedModel, { allowUnlistedValue: true })