Repository navigation
chore(deps): update bst2 digest to 2232beb - #548
mergeraptor[bot] wants to merge 2 commits into
Conversation
aba5b5d
ℹ️ Sentinel notice — informational; author is trusted (allow-listed bot), merge is not blockedHive flagged this PR (author @mergeraptor[bot], head
Hive did not add the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Summary: This automated update moves the build-tool container (the "bst2" image our local builds and CI run BuildStream inside) to a newer upstream version. The new version does not exist yet: the upstream project's build for that commit failed, so no image was ever published. Merging this as-is would make every local build and the CI validation step fail with "image not found".
What I need from you: Hold this PR until upstream publishes the image (or Renovate re-targets to a commit that has one); do not merge now.
correctness
- high — pinned bst2 tag does not exist in the registry.
Justfile:10now setsbst2_imageto...bst2:e9149d58061b3d388e6be42a39e1fab5ffa80bdc, and everyjust bstinvocation (Justfile:51) pulls it. Thevalidatecheck on this head fails withreading manifest e9149d58… : manifest unknown(job 122279234304). Verified against GitLab directly: registry tag lookup returns404 Tag Not Found, and the upstreammasterpipeline for commite9149d5(MR !800, "Upgrade container to 26.08.4") has status failed (pipeline 2994833247), so the image was never built. The previous tag0fadcdc…still resolves. Fix: wait for upstream to publish (then tick the rebase/retry box so Renovate re-validates), or leave on0fadcdcuntil a later master commit has a published tag.
docs-currency (out-of-scope, backlog)
- low — docs assert every upstream merge publishes a tag; this PR shows that is not guaranteed.
docs/skills/ci-tooling.md:72-73("every merge there publishes a tag for its commit") and the matchingrenovate.json:31description are the rationale for followingmasterwithgit-refs. A failed upstream pipeline leaves a merge with no tag, which is exactly what happened here. Worth softening the wording and/or adding an existence check (e.g. a manifest HEAD beforejust bstinvalidate) so the failure mode is explicit rather than a baremanifest unknown.
No findings from: security, intent-alignment, style.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Not mergeable yet: the bumped image doesn't exist. |
|
This mergeraptor PR has failed |
aba5b5d to
2ba81a5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
2ba81a5
ℹ️ Sentinel notice — informational; author is trusted (allow-listed bot), merge is not blockedHive flagged this PR (author @mergeraptor[bot], head
Hive did not add the |
There was a problem hiding this comment.
Summary: This automated update points our build tooling at a newer version of a container image used to run BuildStream, but that newer version was never actually published: the image's upstream build failed, so pulling it fails and our own validation check breaks. Merging as-is would leave every just bst/just validate run broken until someone changes the pin again.
What I need from you: Don't merge this; wait for upstream to publish the image (or let Renovate re-propose once a working commit exists).
correctness
- high, in-scope —
Justfile:10now pinsbst2:2232beb539e95b5c18f64d418fcdff18bf2ea530, but that tag does not exist in the registry.GET /v2/.../bst2/manifests/2232beb…returns 404 (the previous0fadcdc…returns 200); the tags list contains only2232beb…-arm64,-ppc64le,-riscv64— no-amd64and no multi-arch index. Upstream pipeline for that commit isfailed(https://gitlab.com/freedesktop-sdk/infrastructure/freedesktop-sdk-docker-images/-/pipelines/2998809721). CIvalidateon this head fails atJustfile:51(podman run … "{{bst2_image}}"):reading manifest 2232beb… : manifest unknown, exit 125. Fix: keep0fadcdc…until upstream publishes a complete image for a master commit, then re-run Renovate (rebase/retry checkbox). - low, out-of-scope —
renovate.json:31-43tracksgit-refson upstreammaster, which races against the image publish: any master commit whose pipeline fails or is still running yields an unpullable pin like this one. Consider a post-upgrade check or switching the datasource to the registry's tag list filtered to 40-hex tags that have a manifest.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Nothing to do on this PR: the tag doesn't exist yet. Renovate will move this PR to the next commit that publishes a tag. Once |
The bst2:2232beb539e95b5c18f64d418fcdff18bf2ea530 tag does not exist in the GitLab registry (upstream image pipeline 2998809721 failed), so podman run in the validate job fails with 'manifest unknown'. Restore the last published pin. Hive-Fix-Attempt: 4/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull request changes no files, so there is nothing to approve. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
Summary: This update was meant to move the build-tool container image to a newer version, but that newer image was never published upstream, so the last fix reverted the change. The pull request now changes nothing at all: merging it would record "updated to the new version" in history while the version stays exactly where it is. It should be closed rather than merged; the next upstream build will produce a fresh update.
What I need from you: Close this PR (do not merge the empty diff).
Reviewed delta 2ba81a5…6041d60 (Justfile, 2 lines). Head Justfile:10 now pins bst2:0fadcdcabdb66c7b6cd3721072fd41abe38f5c10, byte-identical to main Justfile:10; compare/main...6041d60 reports files: [] and prow already notes "This pull request changes no files".
intent-alignment
- medium, in-scope — Title/body promise
0fadcdc → 2232beb, but the net diff againstmainis empty (Justfile:10 at head == main). Merging records a dependency bump that did not happen. Registry check at review time:bst2:2232beb…manifest → 404,bst2:0fadcdc…→ 200, so the bump still cannot land. Remediation: close this PR; Renovate will open a new one for the next published upstream commit. Renovate also will not rebase this branch anymore (its "Edited/Blocked" comment), so leaving it open gains nothing.
correctness
- Previous finding "Justfile:10 pinned tag not published; validate fails" — fixed by the revert;
validatecheck-run issuccessat head. - Previous finding "renovate.json:31 git-refs tracking races upstream image publish" — still present, now out-of-scope (renovate.json untouched by this PR). renovate.json:31–43 follows
masterof the upstream git repo viagit-refs, so every upstream merge whose image pipeline fails (as 2998809721 did) yields another unmergeable PR. Backlog: gate on image existence (e.g. docker datasource +versioningthat can order the tags, or a pre-merge tag probe invalidate).
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull request changes no files, so there is nothing to approve. |
|
Closing per the hive review: the bst2 |
This PR contains the following updates:
0fadcdc→2232bebConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.