[3.14] gh-161076: Ignore setsockopt(TCP_NODELAY) errors in asyncio (GH-161253) (#161302)

gh-161076: Ignore setsockopt(TCP_NODELAY) errors in asyncio (GH-161253)
(cherry picked from commit 405f127)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

Author: miss-islington

Lib/asyncio/base_events.py

@@ -193,7 +193,13 @@ def _set_nodelay(sock):
         if (sock.family in {socket.AF_INET, socket.AF_INET6} and
                 sock.type == socket.SOCK_STREAM and
                 sock.proto == socket.IPPROTO_TCP):
-            sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+            try:
+                sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+            except OSError:
+                # TCP_NODELAY is only a latency optimization.  It can fail
+                # on a connection already reset by the peer (e.g. EINVAL
+                # on macOS); the error will surface on the next I/O.
+                pass
 else:
     def _set_nodelay(sock):
         pass

Lib/test/test_asyncio/test_base_events.py

@@ -2330,6 +2330,17 @@ def test_set_nodelay(self):
             sock.setblocking(False)
             self.check_set_nodelay(sock)
 
+    @unittest.skipUnless(hasattr(socket, 'TCP_NODELAY'),
+                         'need socket.TCP_NODELAY')
+    def test_set_nodelay_error(self):
+        # gh-161076: a failing setsockopt() must not break transport creation.
+        sock = mock.Mock(family=socket.AF_INET, type=socket.SOCK_STREAM,
+                         proto=socket.IPPROTO_TCP)
+        sock.setsockopt.side_effect = OSError(errno.EINVAL, 'Invalid argument')
+        base_events._set_nodelay(sock)
+        sock.setsockopt.assert_called_once_with(
+            socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+
 
 
 if __name__ == '__main__':

Misc/NEWS.d/next/Library/2026-11-03-12-00-00.gh-issue-161076.nOdLy1.rst

@@ -0,0 +1,5 @@
+Fix :mod:`asyncio` leaving a half-created transport registered with the
+event loop and the server when setting ``TCP_NODELAY`` on a socket fails.
+Such a failure could make :meth:`asyncio.Server.wait_closed` hang and
+prevent new connections from being served.  Errors from
+``setsockopt(TCP_NODELAY)`` are now ignored.