Repository navigation
[3.10] gh-155694: Scope HTTPPasswordMgr credentials by URL scheme (GH-155696) - #155973
Merged
Merged
Conversation
…honGH-155696) Credentials stored for an https:// URI were also matched against the corresponding http:// URI, since `reduce_uri()` discards the scheme. `HTTPPasswordMgr` and `HTTPPasswordMgrWithPriorAuth` now compare the scheme too; URIs registered without a scheme still match any scheme. (cherry picked from commit a7bb524) Co-authored-by: Łukasz <lukaszlapinski7@gmail.com>
This was referenced Aug 17, 2026
Eclips4
reviewed
Aug 18, 2026
Unfortunately, too old Sphinx
Documentation build overview
577 files changed ·
|
Eclips4
approved these changes
Aug 18, 2026
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
Oct 28, 2026
…me (pythonGH-155696) (python#155973) * pythongh-155694: Scope HTTPPasswordMgr credentials by URL scheme (pythonGH-155696) Credentials stored for an https:// URI were also matched against the corresponding http:// URI, since `reduce_uri()` discards the scheme. `HTTPPasswordMgr` and `HTTPPasswordMgrWithPriorAuth` now compare the scheme too; URIs registered without a scheme still match any scheme. (cherry picked from commit a7bb524) Co-authored-by: Łukasz <lukaszlapinski7@gmail.com> * Apply suggestion from @Eclips4 Unfortunately, too old Sphinx * Empty commit to triger CI --------- Co-authored-by: Łukasz <lukaszlapinski7@gmail.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> (cherry picked from commit dac88d8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credentials stored for an https:// URI were also matched against the
corresponding http:// URI, since
reduce_uri()discards the scheme.HTTPPasswordMgrandHTTPPasswordMgrWithPriorAuthnow compare the schemetoo; URIs registered without a scheme still match any scheme.
(cherry picked from commit a7bb524)
Co-authored-by: Łukasz lukaszlapinski7@gmail.com
HTTPPasswordMgrcan send saved HTTPS credentials via HTTP because of incorrect scheme matching #155694