From 388bc0c1274066fe1240778f976771fb97df324b Mon Sep 17 00:00:00 2001 From: baku-ccron Date: Fri, 21 Aug 2026 15:57:19 +0000 Subject: [PATCH] chore: remove the submodule-era residue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `foundry.lock` is Foundry's git-submodule lockfile: it pins the commit each dependency vendored under `lib/` is checked out at. This repo has no `.gitmodules`, no `lib/` and no gitlinks — dependencies come from soldeer, `foundry.toml` sets `libs = ["dependencies"]`, and `soldeer.lock` is the live lockfile. The two disagreed: `foundry.lock` pinned `lib/forge-std` at b8f065fd (an untagged 2025-10-14 forge-std commit) while the build has been using 1.16.1 the whole time. Nothing reconciled them because nothing read the `foundry.lock` side. It was not silent. `forge build` emitted one warning per entry: Warning: Dependency 'lib/forge-std' not found at expected path Submodules cannot come back either — rainix CI runs a `no-submodules` check that fails on a root `.gitmodules` or any committed gitlink. Removing the file alone would have left the references behind, so this takes all of them in one pass: - `foundry.lock` deleted. - `REUSE.toml` drops its `"foundry.lock"` annotation entry. - `.soldeerignore` drops `/foundry.lock` and `/lib`, plus three more entries found while checking that name nothing in this tree: `.gitmodules`, `.coderabbit.yaml` (no such file here, not gitignored; the org repos that have one spell it `.coderabbitai.yaml`) and `CLAUDE.md` (this repo has none). `.gas-snapshot` stays — that file does exist. So do `.DS_Store`, `.vscode`, `.pre-commit-config.yaml` and the build/publish outputs (`/out`, `/cache`, `/dependencies`, `/remappings.txt`): absent from a clean checkout by design, present when `soldeer push` runs. - `slither.config.json` `filter_paths` moves from `lib/forge-std` to `dependencies/forge-std-`, which is where forge-std actually lands (`dependencies/forge-std-1.16.1/`). The prefix stops short of the version so a bump does not silently blank the filter again. Configuration only. No Solidity source, no deployed bytecode, no audited artifact changes. Co-Authored-By: Claude Opus 5 (1M context) --- .soldeerignore | 5 ----- REUSE.toml | 1 - foundry.lock | 5 ----- slither.config.json | 2 +- 4 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 foundry.lock diff --git a/.soldeerignore b/.soldeerignore index bc7a62c..25aa203 100644 --- a/.soldeerignore +++ b/.soldeerignore @@ -1,22 +1,17 @@ .DS_Store -.coderabbit.yaml .gas-snapshot .git .github .gitignore -.gitmodules .pre-commit-config.yaml .soldeerignore .vscode -CLAUDE.md /audit /cache /dependencies /flake.lock /flake.nix -/foundry.lock /foundry.toml -/lib /out /remappings.txt /slither.config.json diff --git a/REUSE.toml b/REUSE.toml index 1dc2ad2..8d37aeb 100644 --- a/REUSE.toml +++ b/REUSE.toml @@ -14,7 +14,6 @@ path = [ "foundry.toml", "slither.config.json", "REUSE.toml", - "foundry.lock", "soldeer.lock", ".soldeerignore", ] diff --git a/foundry.lock b/foundry.lock deleted file mode 100644 index 2fa9b50..0000000 --- a/foundry.lock +++ /dev/null @@ -1,5 +0,0 @@ -{ - "lib/forge-std": { - "rev": "b8f065fda83b8cd94a6b2fec8fcd911dc3b444fd" - } -} \ No newline at end of file diff --git a/slither.config.json b/slither.config.json index bd649fe..55c6c6a 100644 --- a/slither.config.json +++ b/slither.config.json @@ -1,4 +1,4 @@ { "detectors_to_exclude": "assembly-usage,solc-version", - "filter_paths": "lib/forge-std,test" + "filter_paths": "dependencies/forge-std-,test" }