Delete stub RCTAppSetupDefaultJsExecutorFactory (#59435)

Summary:
Pull Request resolved: #59435

The default JS executor factory unconditionally returns `nullptr` and has no callers. Delete it with its now-unused imports and forward declarations, narrowing the header to forward declarations.

Changelog: [Internal]

Reviewed By: andrewdacenko

Differential Revision: D127294774

Author: christophpurrer

packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h

@@ -6,32 +6,21 @@
  */
 
 #import <Foundation/Foundation.h>
-#import <React/RCTBridge.h>
-#import <React/RCTRootView.h>
 
-#ifdef __cplusplus
+@class RCTBridge;
+@class RCTRootView;
 
-#import <memory>
+#ifdef __cplusplus
 
 #import <ReactCommon/RCTTurboModuleManager.h>
 
 @protocol RCTDependencyProvider;
 
-// Forward declaration to decrease compilation coupling
-namespace facebook::react {
-class JSExecutorFactory;
-class RuntimeScheduler;
-} // namespace facebook::react
 RCT_EXTERN NSArray<NSString *> *RCTAppSetupUnstableModulesRequiringMainQueueSetup(
     id<RCTDependencyProvider> dependencyProvider);
 
 RCT_EXTERN id<RCTTurboModule> RCTAppSetupDefaultModuleFromClass(
     Class moduleClass,
     id<RCTDependencyProvider> dependencyProvider);
 
-std::unique_ptr<facebook::react::JSExecutorFactory> RCTAppSetupDefaultJsExecutorFactory(
-    RCTBridge *bridge,
-    RCTTurboModuleManager *turboModuleManager,
-    const std::shared_ptr<facebook::react::RuntimeScheduler> &runtimeScheduler);
-
 #endif // __cplusplus

packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm

@@ -7,10 +7,6 @@
 
 #import "RCTAppSetupUtils.h"
 
-#import <cxxreact/JSExecutor.h>
-#import <react/renderer/runtimescheduler/RuntimeScheduler.h>
-#import <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
-
 // Turbo Module
 #import <React/RCTBundleAssetImageLoader.h>
 #import <React/RCTDataRequestHandler.h>
@@ -92,11 +88,3 @@
   // No custom initializer here.
   return [moduleClass new];
 }
-
-std::unique_ptr<facebook::react::JSExecutorFactory> RCTAppSetupDefaultJsExecutorFactory(
-    RCTBridge *bridge,
-    RCTTurboModuleManager *turboModuleManager,
-    const std::shared_ptr<facebook::react::RuntimeScheduler> &runtimeScheduler)
-{
-  return nullptr;
-}

packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm

@@ -6,6 +6,7 @@
  */
 
 #import "RCTDefaultReactNativeFactoryDelegate.h"
+#import <React/RCTRootView.h>
 #import <ReactCommon/RCTHost.h>
 #import "RCTAppSetupUtils.h"
 #import "RCTDependencyProvider.h"
@@ -47,10 +48,13 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory
 #endif
 }
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (void)customizeRootView:(RCTRootView *)rootView
 {
   // Override point for customization after application launch.
 }
+#pragma clang diagnostic pop
 
 - (RCTColorSpace)defaultColorSpace
 {