Skip to content

Commit 9b34616

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Delete deprecated FabricSurface bridge init and stub category (#59438)
Summary: Pull Request resolved: #59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
1 parent 47d343b commit 9b34616

7 files changed

Lines changed: 0 additions & 50 deletions

File tree

‎packages/react-native/React/Fabric/Surface/RCTFabricSurface.h‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
NS_ASSUME_NONNULL_BEGIN
1212

13-
@class RCTBridge;
1413
@class RCTSurfaceView;
1514
@class RCTSurfacePresenter;
1615

@@ -118,15 +117,4 @@ NS_ASSUME_NONNULL_BEGIN
118117

119118
@end
120119

121-
@interface RCTFabricSurface (Deprecated)
122-
123-
/**
124-
* Deprecated. Use `initWithSurfacePresenter:moduleName:initialProperties` instead.
125-
*/
126-
- (instancetype)initWithBridge:(RCTBridge *)bridge
127-
moduleName:(NSString *)moduleName
128-
initialProperties:(NSDictionary *)initialProperties;
129-
130-
@end
131-
132120
NS_ASSUME_NONNULL_END

‎packages/react-native/React/Fabric/Surface/RCTFabricSurface.mm‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -300,17 +300,6 @@ - (void)handleContentSizeCategoryDidChangeNotification:(NSNotification *)notific
300300
return *_surfaceHandler;
301301
}
302302

303-
#pragma mark - Deprecated
304-
305-
- (instancetype)initWithBridge:(RCTBridge *)bridge
306-
moduleName:(NSString *)moduleName
307-
initialProperties:(NSDictionary *)initialProperties
308-
{
309-
return [self initWithSurfacePresenter:bridge.surfacePresenter
310-
moduleName:moduleName
311-
initialProperties:initialProperties];
312-
}
313-
314303
- (NSNumber *)rootViewTag
315304
{
316305
return @(_surfaceHandler->getSurfaceId());

‎packages/react-native/React/Modules/RCTSurfacePresenterStub.h‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,6 @@ NS_ASSUME_NONNULL_BEGIN
3838

3939
@end
4040

41-
@interface RCTBridge (RCTSurfacePresenterStub)
42-
43-
- (id<RCTSurfacePresenterStub>)surfacePresenter;
44-
- (void)setSurfacePresenter:(id<RCTSurfacePresenterStub>)presenter;
45-
46-
@end
47-
4841
@interface RCTBridgeProxy (RCTSurfacePresenterStub)
4942

5043
- (id<RCTSurfacePresenterStub>)surfacePresenter;

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ category RCTBridge(RCTImageLoader) {
1717
public @property (assign, readonly) RCTImageLoader* imageLoader;
1818
}
1919

20-
category RCTBridge(RCTSurfacePresenterStub) {
21-
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
22-
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
23-
}
24-
2520
category RCTBridge(RCTUIManager) {
2621
public @property (assign, readonly) RCTUIManager* uiManager;
2722
}

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ category RCTBridge(RCTImageLoader) {
1717
public @property (assign, readonly) RCTImageLoader* imageLoader;
1818
}
1919

20-
category RCTBridge(RCTSurfacePresenterStub) {
21-
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
22-
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
23-
}
24-
2520
category RCTBridge(RCTUIManager) {
2621
public @property (assign, readonly) RCTUIManager* uiManager;
2722
}

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ category RCTBridge(RCTImageLoader) {
1717
public @property (assign, readonly) RCTImageLoader* imageLoader;
1818
}
1919

20-
category RCTBridge(RCTSurfacePresenterStub) {
21-
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
22-
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
23-
}
24-
2520
category RCTBridge(RCTUIManager) {
2621
public @property (assign, readonly) RCTUIManager* uiManager;
2722
}

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ category RCTBridge(RCTImageLoader) {
1717
public @property (assign, readonly) RCTImageLoader* imageLoader;
1818
}
1919

20-
category RCTBridge(RCTSurfacePresenterStub) {
21-
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
22-
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
23-
}
24-
2520
category RCTBridge(RCTUIManager) {
2621
public @property (assign, readonly) RCTUIManager* uiManager;
2722
}

0 commit comments

Comments
 (0)