Repository navigation
Fix shadowColor and outline prop defaults in BaseViewManagerDelegate - #59423
Merged
meta-codesync[bot] merged 1 commit intoOct 28, 2026
Merged
meta-codesync[bot] merged 1 commit into
meta-codesync[bot] merged 1 commit into
Conversation
BaseViewManagerDelegate reset shadowColor to 0 and outlineOffset and outlineWidth to YogaConstants.UNDEFINED when the props were removed, instead of the @ReactProp defaults in BaseViewManager (Color.BLACK and 0f). On components with a codegen delegate, removing shadowColor hid the elevation shadow and removing outlineOffset hid the outline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Visual regression1 visual difference(s) at ios: no capture android
|
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D127789219. |
Collaborator
|
This pull request was successfully merged by @shubh73 in dfed2d9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
BaseViewManagerDelegateresets three props to values that don't match the@ReactPropdefaults inBaseViewManagerwhen they're removed:BaseViewManagerdefaultBaseViewManagerDelegateshadowColorColor.BLACK0outlineOffset0fYogaConstants.UNDEFINEDoutlineWidth0fYogaConstants.UNDEFINEDThis affects every component whose view manager uses a codegen delegate (e.g.
Switch,Modal,RefreshControl, and third-party Fabric components), but notView. RemovingshadowColorfrom a view withelevationmakes the shadow disappear instead of going back to black, and removingoutlineOffsetmakes the outline disappear instead of drawing it with no offset.This makes the delegate use the same defaults as
BaseViewManager.Changelog:
[ANDROID] [FIXED] - Fix
shadowColor,outlineOffsetandoutlineWidthnot resetting to their defaults on components with a codegen view manager delegateTest Plan:
Added
setShadowColorResetsToBlack,setOutlineOffsetResetsToZeroandsetOutlineWidthResetsToZerotoBaseViewManagerDelegateTest. They pass with this change and fail without it (0instead of-16777216,NaNfinstead of0.0f).Also checked in RNTester on an OPPO K12x 5G (CPH2667, Android 16) with a
Viewand aSwitchside by side, each withelevation+shadowColor: 'red'andoutlineWidth+outlineOffset: 8, then removingshadowColorandoutlineOffset:Viewresets correctly; onSwitchthe shadow and the outline both disappear.SwitchmatchesView(black shadow, outline with no offset).🤖 Generated with Claude Code