From df02f1cf0624f61c5e48df667be20248bc2c2c75 Mon Sep 17 00:00:00 2001 From: Twan Kranenburg Date: Mon, 9 Nov 2026 14:27:52 +0100 Subject: [PATCH 1/3] take aria-hidden from theme and add to dt table itself --- R/ro_dt_table.R | 18 ++++++++++++++++++ R/ro_dt_theme.R | 12 ------------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/R/ro_dt_table.R b/R/ro_dt_table.R index 46db7a9..941467a 100644 --- a/R/ro_dt_table.R +++ b/R/ro_dt_table.R @@ -50,6 +50,24 @@ ro_dt_table <- function(data, caption, sorting = FALSE, pagelength = 10) { ), callback = JS( " + // Inject screen-reader-only style once (not dependent on host Bootstrap version) + if (!document.getElementById('ro-dt-table-visually-hidden-style')) { + var style = document.createElement('style'); + style.id = 'ro-dt-table-visually-hidden-style'; + style.innerHTML = '.visually-hidden {' + + 'position: absolute !important;' + + 'width: 1px !important;' + + 'height: 1px !important;' + + 'padding: 0 !important;' + + 'margin: -1px !important;' + + 'overflow: hidden !important;' + + 'clip: rect(0, 0, 0, 0) !important;' + + 'white-space: nowrap !important;' + + 'border: 0 !important;' + + '}'; + document.head.appendChild(style); + } + // Add ARIA role and label to pagination function addPaginationARIA() { var $container = $(table.table().container()); diff --git a/R/ro_dt_theme.R b/R/ro_dt_theme.R index 313f2b8..5449fd4 100644 --- a/R/ro_dt_theme.R +++ b/R/ro_dt_theme.R @@ -216,18 +216,6 @@ ro_dt_theme <- function( box-shadow: none !important; } - /* Screen-reader-only text (not dependent on host Bootstrap version) */ - .visually-hidden { - position: absolute !important; - width: 1px !important; - height: 1px !important; - padding: 0 !important; - margin: -1px !important; - overflow: hidden !important; - clip: rect(0, 0, 0, 0) !important; - white-space: nowrap !important; - border: 0 !important; - } ", base_family, base_family, From 6a235f02f52bd95c6b440f83e5b12e941ece46db Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 9 Nov 2026 13:38:26 +0000 Subject: [PATCH 2/3] Fix lintr by installing the local package Co-authored-by: tkranenburgrivm <235857189+tkranenburgrivm@users.noreply.github.com> --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2a52386..f6c2b54 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -49,7 +49,7 @@ jobs: # R is already baked into daratools/robase - no setup-r needed. - uses: r-lib/actions/setup-r-dependencies@v2 with: - extra-packages: any::lintr + extra-packages: any::lintr, local::. needs: lint # Deliberately doesn't use LINTR_ERROR_ON_LINT here: we need the lint From 7c678852f93d945681ea147aabe325a919395955 Mon Sep 17 00:00:00 2001 From: Veerle van Leemput Date: Mon, 9 Nov 2026 14:51:50 +0100 Subject: [PATCH 3/3] Revert "Fix lintr by installing the local package" No longer needed: main already silences missing_package_linter in the vignette (same as the other ROvis repos), so ci.yaml stays identical across the suite. This reverts commit 6a235f0. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 403f57e..430c3a3 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -49,7 +49,7 @@ jobs: # R is already baked into daratools/robase - no setup-r needed. - uses: r-lib/actions/setup-r-dependencies@f9a764fea8d5c63df6ef9a5c7795bf7deb5d7e05 # v2.14.0 with: - extra-packages: any::lintr, local::. + extra-packages: any::lintr needs: lint # Deliberately doesn't use LINTR_ERROR_ON_LINT here: we need the lint