Skip to content

Wrong PLL with armclk #384

Description

@electrofloat

So this patch: 3151edc#diff-850d563678ee4847d48ba244e6df416800106cf80b972598e81690637f2a2d39

refactored the handling of clk to not use a function call. But a serious bug was introduced in it, namely NPLL has been replaced with APLL (I only checked rk3328, but probably all of them concerned). This makes the devices really slow.

I don't understand how this bug went unnoticed since 2021.

The upstream kernel is still correctly uses the array with the correct indexes: https://github.com/torvalds/linux/blob/master/drivers/clk/rockchip/clk-rk3328.c#L911

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions