From 9c0585c33344e2fb9b0cfecfef507c7ea68679e2 Mon Sep 17 00:00:00 2001 From: Chris Lenz Date: Tue, 22 Sep 2026 10:12:00 +0200 Subject: [PATCH] fix: name is not required filed for token generation --- pkg/cmd/apigw/apigw_test.go | 11 +++++------ pkg/cmd/apigw/generate.go | 3 --- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/pkg/cmd/apigw/apigw_test.go b/pkg/cmd/apigw/apigw_test.go index 17243c5..3166fca 100644 --- a/pkg/cmd/apigw/apigw_test.go +++ b/pkg/cmd/apigw/apigw_test.go @@ -172,18 +172,17 @@ func TestGenerateTokenCmd(t *testing.T) { args: []string{"token", "--priv", privPath, "--sub", "user1", "--name", "Test User", "--preferred-username", "testuser"}, wantErr: false, }, + { + name: "valid token without name", + args: []string{"token", "--priv", privPath, "--sub", "user1", "--preferred-username", "testuser"}, + wantErr: false, + }, { name: "missing sub", args: []string{"token", "--priv", privPath, "--name", "Test User", "--preferred-username", "testuser"}, wantErr: true, errMsg: "required flag(s) \"sub\" not set", }, - { - name: "missing name", - args: []string{"token", "--priv", privPath, "--sub", "user1", "--preferred-username", "testuser"}, - wantErr: true, - errMsg: "required flag(s) \"name\" not set", - }, { name: "missing preferred-username", args: []string{"token", "--priv", privPath, "--sub", "user1", "--name", "Test User"}, diff --git a/pkg/cmd/apigw/generate.go b/pkg/cmd/apigw/generate.go index 97d6a6d..c2dc594 100644 --- a/pkg/cmd/apigw/generate.go +++ b/pkg/cmd/apigw/generate.go @@ -71,9 +71,6 @@ func newTokenCmd() *cobra.Command { if err := cmd.MarkFlagRequired(flagSub); err != nil { panic(err) } - if err := cmd.MarkFlagRequired(flagName); err != nil { - panic(err) - } if err := cmd.MarkFlagRequired(flagPreferredUser); err != nil { panic(err) }