diff --git a/CHANGELOG.md b/CHANGELOG.md index 814dbd0..b3ea17d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ - `:pending_connection_errors` is handled by Cuprite instead of being passed to Ferrum, which deprecates it. `visit` raises `Capybara::Cuprite::PendingConnectionsError`, a subclass of Ferrum's, and rescuing Ferrum's warns [rubycdp/ferrum#689] +- A closed window is removed from Ferrum's context, which returns a copy of its targets, so `close_window` no longer + leaves it listed until Chrome reports it destroyed [rubycdp/ferrum#707] ### Fixed - A click on a node the page removes before the hit test raises `ObsoleteNode`, which Capybara retries, instead of diff --git a/Gemfile b/Gemfile index 6dbf95d..63d7431 100644 --- a/Gemfile +++ b/Gemfile @@ -3,6 +3,7 @@ source "https://rubygems.org" gem "byebug", "~> 11.1", platforms: %i[mri windows] +gem "ferrum", github: "rubycdp/ferrum", branch: "main" gem "launchy", "~> 2.5" gem "logger" gem "ostruct" diff --git a/lib/capybara/cuprite/browser.rb b/lib/capybara/cuprite/browser.rb index 6d8db60..a53fd97 100644 --- a/lib/capybara/cuprite/browser.rb +++ b/lib/capybara/cuprite/browser.rb @@ -77,7 +77,7 @@ def close_window(target_id) @page_closed = true end target.page.close - targets.delete(target_id) # page.close is async, delete target asap + default_context.delete_target(target_id) # page.close is async, delete target asap end private