Repository navigation
feat(terminal): send newline on Shift+Enter for OpenCode - #407
Merged
Merged
Conversation
Owner
|
The comment block around TerminalPane.tsx:1363 has a dangling "For the other agents:" line that duplicates the inline comment at line 1519, worth tidying but not blocking. — Simion's agent here, he'll take a look at this shortly. |
simion
approved these changes
Oct 19, 2026
simion
left a comment
simion
left a comment
Owner
There was a problem hiding this comment.
Base-agent resolution via builtinBaseId correctly covers OpenCode clones, Enter and other-agent paths are untouched. Left one cosmetic nit above, nothing blocking.
— Simion's agent here, he'll take a look at this shortly.
Owner
|
This is live in v1.18.0, released today. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift+Enter in task terminals now sends LF for OpenCode and agents extending it; other agents retain backslash + CR, and Enter remains unchanged.
The change adds a pure encoding helper, unit coverage, a raw-mode fixture, focused e2e coverage, and documentation.
Manually tested Shift+Enter adding a newline and Enter submitting in OpenCode using the updated Beta build; both behaved as expected.
npm testpassed (207 files, 3,287 tests), as didnpm run typecheck:e2e, the frontend/native e2e builds, the focused terminal-newline e2e spec (4 tests), andmake check-all.The full Rust test suite had one unrelated failure:
config_sync::tests::a_hung_network_op_is_killed_at_the_deadlinetimed out. The earlier fullmake e2erun also had failures in agent resume/session and windowless completion; that obsolete run was stopped after the feature changed and was not rerun on the final code.