You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Strict typing for walmart/store + lowes/store plugin params
Scrape.do's async-api/plugins page now formally documents the schema
for both `walmart/store` and `lowes/store`. Replace the
`extra="allow"` schema-free passthrough with proper typed fields and
cross-field validators.
WalmartStoreParameters:
- `url` (required, must contain walmart.com)
- `zipcode` + `storeid` conditional pair (both or neither; setting
only one raises ValidationError)
- gateway-side toggles: disableretry, transparentresponse, timeout
(5000-120000ms)
LowesStoreParameters:
- `url` (required, must contain lowes.com)
- `zipcode` (required, digits-only)
- `storeid` (required, digits-only)
- same gateway-side toggles as Walmart
Tests:
- tests/unit/async_api/models/plugins/test_additional.py expanded to
cover every required-field / cross-field / format-validation case.
- tests/unit/async_api/models/plugins/test_discriminated_union.py
walmart/lowes cases updated to use the new required-field combos.
- Integration plugin sweep re-introduces `google/trends` and
`lowes/store` now that the pass criterion (`assert_request_accepted`)
tolerates upstream/engine transient failures. The plugin engine's
HTTP 400 parameter rejection is still surfaced as a test failure.
Breaking change for callers passing undocumented extras through the
previous schema-free passthrough.
Copy file name to clipboardExpand all lines: .github/CHANGELOG.md
+6Lines changed: 6 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -8,10 +8,16 @@ All notable changes to this project will be documented in this file.
8
8
9
9
## [Unreleased]
10
10
11
+
### Changed
12
+
13
+
-**`WalmartStoreParameters` / `LowesStoreParameters`** now enforce the documented schema from `Scrape.do's` async-api/plugins page instead of accepting arbitrary extras via `extra="allow"`. Walmart requires `url` (walmart.com domain) and treats `zipcode` + `storeid` as a conditional pair (both or neither). Lowes requires `url` (lowes.com domain) plus digit-only `zipcode` and `storeid`. Both pick up the gateway-side `disableretry` / `transparentresponse` / `timeout` knobs. Breaking change for callers passing undocumented extras through the previous schema-free passthrough.
14
+
11
15
### Internal
12
16
13
17
- Integration suite standardized around three test categories — content-dependent tests retry on transient Scrape.do gateway failures, shape-dependent tests assert only that the request wasn't rejected (HTTP 400), and error-routing tests are unchanged.
14
18
19
+
- Re-introduced `google/trends` and `lowes/store` into the live plugin sweep now that the pass criterion tolerates upstream / engine-side transient failures.
Copy file name to clipboardExpand all lines: docs/changelog.md
+6Lines changed: 6 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -10,10 +10,16 @@
10
10
11
11
## `Unreleased`
12
12
13
+
### Changed
14
+
15
+
-**[`WalmartStoreParameters`][scrape_do.async_api.models.plugins.WalmartStoreParameters] / [`LowesStoreParameters`][scrape_do.async_api.models.plugins.LowesStoreParameters]** now enforce the documented schema from `Scrape.do's` async-api/plugins page instead of accepting arbitrary extras via `extra="allow"`. Walmart requires `url` (walmart.com domain) and treats `zipcode` + `storeid` as a conditional pair (both or neither). Lowes requires `url` (lowes.com domain) plus digit-only `zipcode` and `storeid`. Both pick up the gateway-side `disableretry` / `transparentresponse` / `timeout` knobs. Breaking change for callers passing undocumented extras through the previous schema-free passthrough.
16
+
13
17
### Internal
14
18
15
19
- Integration suite standardized around three test categories — content-dependent tests retry on transient Scrape.do gateway failures, shape-dependent tests assert only that the request wasn't rejected (HTTP 400), and error-routing tests are unchanged.
16
20
21
+
- Re-introduced `google/trends` and `lowes/store` into the live plugin sweep now that the pass criterion tolerates upstream / engine-side transient failures.
0 commit comments