From 3ce69c7e825d5bcf492ed2644cd9e3518f8f0fb9 Mon Sep 17 00:00:00 2001 From: Ryan Lee Date: Tue, 6 Oct 2026 22:36:40 -0400 Subject: [PATCH] chore: drop macOS from CI (hosted larger-runner quota) macos-14 and macos-latest are billed as "larger" GitHub-hosted runners even on public repos, so every CI run on them burns the org's Actions quota. This removes macOS from the CI/test matrix (and from comment-checker's release/distribution matrix per Ryan: no macOS build at all) while keeping the ubuntu and windows legs intact --- .github/workflows/platform.yml | 8 -------- .github/workflows/tools.yml | 2 +- release.jsonc | 16 ---------------- scripts/lib/targets.json | 16 ---------------- scripts/tools/check-matrix.ts | 4 ++-- 5 files changed, 3 insertions(+), 43 deletions(-) diff --git a/.github/workflows/platform.yml b/.github/workflows/platform.yml index 0dbe604..23736ca 100644 --- a/.github/workflows/platform.yml +++ b/.github/workflows/platform.yml @@ -32,14 +32,6 @@ jobs: suffix: linux-arm64 runner: ubuntu-24.04-arm bin: comment-checker - - target: x86_64-apple-darwin - suffix: darwin-x64 - runner: macos-14 - bin: comment-checker - - target: aarch64-apple-darwin - suffix: darwin-arm64 - runner: macos-14 - bin: comment-checker - target: x86_64-pc-windows-msvc suffix: win32-x64 runner: windows-2022 diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml index 8779d4c..74af11b 100644 --- a/.github/workflows/tools.yml +++ b/.github/workflows/tools.yml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-14, windows-2022] + os: [ubuntu-latest, windows-2022] steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: diff --git a/release.jsonc b/release.jsonc index 3ab1dd2..7e8ff65 100644 --- a/release.jsonc +++ b/release.jsonc @@ -45,22 +45,6 @@ "runner": "ubuntu-24.04-arm", "bin": "comment-checker", }, - { - "target": "x86_64-apple-darwin", - "suffix": "darwin-x64", - "os": "darwin", - "cpu": "x64", - "runner": "macos-14", - "bin": "comment-checker", - }, - { - "target": "aarch64-apple-darwin", - "suffix": "darwin-arm64", - "os": "darwin", - "cpu": "arm64", - "runner": "macos-14", - "bin": "comment-checker", - }, { "target": "x86_64-pc-windows-msvc", "suffix": "win32-x64", diff --git a/scripts/lib/targets.json b/scripts/lib/targets.json index 64b7f14..bcedfd3 100644 --- a/scripts/lib/targets.json +++ b/scripts/lib/targets.json @@ -17,22 +17,6 @@ "runner": "ubuntu-24.04-arm", "bin": "comment-checker" }, - { - "target": "x86_64-apple-darwin", - "suffix": "darwin-x64", - "os": "darwin", - "cpu": "x64", - "runner": "macos-14", - "bin": "comment-checker" - }, - { - "target": "aarch64-apple-darwin", - "suffix": "darwin-arm64", - "os": "darwin", - "cpu": "arm64", - "runner": "macos-14", - "bin": "comment-checker" - }, { "target": "x86_64-pc-windows-msvc", "suffix": "win32-x64", diff --git a/scripts/tools/check-matrix.ts b/scripts/tools/check-matrix.ts index e31016c..5c49505 100755 --- a/scripts/tools/check-matrix.ts +++ b/scripts/tools/check-matrix.ts @@ -13,12 +13,12 @@ import { // The product platform set: a known list the table must name, not a copy // derived from the table under check. -const EXPECTED_SUFFIXES = ['linux-x64', 'linux-arm64', 'darwin-x64', 'darwin-arm64', 'win32-x64'] +const EXPECTED_SUFFIXES = ['linux-x64', 'linux-arm64', 'win32-x64'] // Known-good hosted runners. The release workflow's per-row runner must match // the table's canonical runner AND be one of these — a retired or mistyped // label (e.g. macos-13) must fail the gate, not pass it (issue #8 refit). -const KNOWN_RUNNERS = new Set(['ubuntu-latest', 'ubuntu-24.04-arm', 'macos-14', 'windows-2022']) +const KNOWN_RUNNERS = new Set(['ubuntu-latest', 'ubuntu-24.04-arm', 'windows-2022']) const failures: string[] = [] const fail = (reason: string) => failures.push(reason)