Skip to content

determine if domain is valid in 'certs:attach <cert> <domain>' #31

Description

@Cryptophobia

From @arschles on March 15, 2016 23:35

Currently, although certs:attach <cert> <domain> will properly error out if <cert> is bogus/non-existent, it doesn't if <domain> is similarly non-existent. Consider the following unit test, which is currently failing (err is nil):

if err := Attach(&client, "test-example-com", "non-existent.domain.com"); err == nil {
   t.Fatal("An Error should have resulted from the attempt to attach a valid cert to a non-existent domain")
 }

This issue tracks work on the client side, and deis/workflow#475 tracks server-side work

Copied from original issue: deis/workflow-cli#24

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions