From 01cad13f7a21788ae3b974f6c5ff8b0c2ea222cb Mon Sep 17 00:00:00 2001 From: roselyn Date: Wed, 4 Nov 2026 14:50:25 +0000 Subject: [PATCH] Fix labels on plugin_repo build def The extract_rule overrides the remote_rule, which means the labels for the remote_rule will never be seen. We need instead to set the labels on the extract_rule, so we actually get the resulting labels. We can't put them on the subrepo rule because it's not a real rule in the same way. But that also means we don't have to worry about the subrepo overriding it from the extract rule --- rules/subrepo_rules.build_defs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/subrepo_rules.build_defs b/rules/subrepo_rules.build_defs index 1bf0e44d4..98e6d9273 100644 --- a/rules/subrepo_rules.build_defs +++ b/rules/subrepo_rules.build_defs @@ -339,7 +339,6 @@ def plugin_repo(name:str, revision:str, plugin:str="", owner:str="please-build" url = urls, out = name + '_' + basename(urls[0]), hashes = hashes, - labels = labels, ) extract_rule = build_rule( name = name, @@ -350,6 +349,7 @@ def plugin_repo(name:str, revision:str, plugin:str="", owner:str="please-build" '$TOOL x "$SRCS" -o _tmp', 'mv $(dirname $(ls _tmp/*/.plzconfig)) "$OUT"', ]), + labels = labels, _subrepo = True, )