From 27ab1b32a7b2d7fbb7a6a7b70643e0cf9ae0cb0b Mon Sep 17 00:00:00 2001 From: mertushka Date: Sun, 11 Oct 2026 19:22:53 +0300 Subject: [PATCH] fix: update libdatachannel to 0.24.6 --- CMakeLists.txt | 2 +- docs/development.md | 5 +++++ wpt-manifest.json | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index abda76e..8ab7b7c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -45,7 +45,7 @@ execute_process( string(REPLACE "\"" "" NODE_ADDON_API_DIR "${NODE_ADDON_API_DIR}") string(REPLACE "\\" "/" NODE_ADDON_API_DIR "${NODE_ADDON_API_DIR}") -set(LIBDATACHANNEL_PINNED_COMMIT "188ec93f6a0b01c2032ddb4c8c013118f7f30232" CACHE STRING +set(LIBDATACHANNEL_PINNED_COMMIT "6b1e2e620f1e37f0eafeee702eaea0043cb305fd" CACHE STRING "Audited libdatachannel commit for this binding.") set(LIBDATACHANNEL_REPOSITORY "https://github.com/paullouisageneau/libdatachannel.git" CACHE STRING diff --git a/docs/development.md b/docs/development.md index 9985ff6..254c38d 100644 --- a/docs/development.md +++ b/docs/development.md @@ -15,6 +15,11 @@ npm run build thread-safe callback dispatch. The build uses `cmake-js` and links `LibDataChannel::LibDataChannelStatic`. +The audited native dependency is libdatachannel v0.24.6, pinned to +`6b1e2e620f1e37f0eafeee702eaea0043cb305fd`. It includes fixes for DTLS startup +ordering, TURN handshake deadlocks, and ICE option separators. The CMake pin +and `wpt-manifest.json` dependency metadata must stay in sync. + If a local `libdatachannel/` checkout exists, CMake verifies it against the pinned commit. Otherwise it fetches the pinned upstream commit with `FetchContent`. diff --git a/wpt-manifest.json b/wpt-manifest.json index faa4b39..abfed89 100644 --- a/wpt-manifest.json +++ b/wpt-manifest.json @@ -1,6 +1,6 @@ { "libdatachannelRepository": "https://github.com/paullouisageneau/libdatachannel.git", - "libdatachannelCommit": "188ec93f6a0b01c2032ddb4c8c013118f7f30232", + "libdatachannelCommit": "6b1e2e620f1e37f0eafeee702eaea0043cb305fd", "wptCommit": "03169f171c797d0953b21d7388561b454fde0ad4", "expectedSelectedSubtests": 620, "selectedSubtestsSha256": "967896888c9496738e4911ec1eff073a1d0fff701352729c3de2e51665e8bb97",