Repository navigation
Write Portable PDB local signature row id - #588
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
|
Thanks for picking this up, @dajiaohuang! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #583.\n\nPortable PDB sequence-points blobs require the StandAloneSig row id in the LocalSignature header. MethodBodyWriter retains the metadata token for PE and Windows PDB use; convert it to an RID only at the portable PDB write site.\n\nValidated with a benign locally compiled Debug assembly containing a local variable and sequence point: the current code emitted the token and System.Reflection.Metadata failed to resolve it (BadImageFormatException); this change emitted RID 1 and resolved a 4-byte signature. The library and synthetic runner built successfully on .NET 6 / .NET 9 SDK/runtime. No Windows PDB test was run.