Repository navigation
fix(ext): accept customer account extension tokens, whose iss is /checkouts (#83) - #85
Merged
Merged
Conversation
…ckouts (#83) shopify_api 1.0.0-rc.5 accepts an extension token whose `iss` is any path on the shop of its `dest` (customer account extensions sign `https://{shop}/checkouts`); admin session tokens still need `/admin`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
/extanswered401to every customer account extension: their session token carriesiss: https://{shop}/checkouts, and only/adminwas accepted.shopify_apito=1.0.0-rc.5(fix(oauth): accept a customer account extension token'sisson its shop shopify_api#35): an extension token'sissmay be any path on the shop of itsdest; admin session tokens still need exactly/admin.Cargo.lockchanges onlyshopify_api,shopify_api_graphql,shopify_api_macros.the_token_of_a_customer_account_extension_is_accepted_on_ext_routes_only(crates/openshop/tests/it/proxy_routes.rs): a token with the claims from the issue gets200on/ext/ping, and the same token gets401 invalid session tokenon the Admin API (/api/functions). It fails on rc.4.Fixedentry underUnreleased.Gate:
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace --lockedall pass locally.🤖 Generated with Claude Code