Repository navigation
Conversation
Author
|
The four Actions runs on head Local fixture-backed tests pass: Engine.IO 41 unit tests + 1 doctest, Socket.IO 42 unit tests + 34 doctests. Independent review also exercised cancellation during callback joining, a withheld disconnect response, reconnect backoff shutdown, and drop during namespace acknowledgement. Normal Clippy has the same warning multiset as canonical base; strict |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an additive managed async connection API that retains ownership of the Socket.IO poll/reconnect task until shutdown completes.
ClientBuilder::connect_managedreturnsManagedClient; callers can awaitshutdownto stop and join the owned task and nested Engine.IO callback tasks. Dropping the handle signals stop and aborts owned work. Existingconnectbehavior and reconnect defaults remain unchanged.Engine.IO callback task controls now retain each task's
JoinHandlewhile awaiting it, so cancellation or concurrent joins cannot lose proof of termination. The managed API and task control are documented in the README/API docs.Validation used local fixtures only. Engine.IO async tests pass (41 unit tests and 1 doctest); Socket.IO async tests pass (42 unit tests and 34 doctests). New regressions demonstrate red against simulated handle-losing implementations and green with the fix: callback join cancellation during the actual
JoinHandleawait, and managed shutdown canceled while a local Engine.IO polling close POST is withheld, followed by peer release and retry. Other fixtures cover stalled connect, namespace readiness, reconnect/auth updates, shutdown during retry, and suppression of late work.cargo check -p rust_engineio -p rust_socketio --all-targets --features async,cargo fmt --all -- --check, andgit diff --checkpass. Normal Clippy completed on the feature and canonical baseline with matching normalized warning diagnostics. Strict Clippy remains blocked before the Socket.IO crate by 80 existing Engine.IO diagnostics, reproduced on canonical baseline; this PR does not claim a strict Clippy pass.