fix(ci): require Go race checks before merging - #35
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are low-risk, with only a non-blocking documentation nit recorded.
Pull request overview
Updates PR CI to require Go race checks before merging and documents the expanded required checks.
Changes:
- Runs
test-raceon every pull request viatask test:go. - Documents all five required merge checks.
File summaries
| File | Description |
|---|---|
CONTRIBUTING.md |
Documents the expanded PR gate. |
.github/workflows/ci.yml |
Runs Go race tests for every PR. |
Review details
Suppressed comments (1)
CONTRIBUTING.md:65
- This changes the PR gate from the two
task checksubtasks to a third requiredtask test:gojob, butARCHITECTURE.md:446-449still describes CI as those two subtasks and presentstask pre-pushas the race-detector addition. Please update that public-contract documentation in this change so maintainers do not get contradictory guidance about which checks are required for a PR.
PR CI 在 Linux 上并行执行 `task check:static`、`task check:test` 与
`task test:go`（Go race detector），同时在 Windows 上执行 `task check`、
macOS 上执行 `task check:test`。master 的保护规则要求 `lint`、`test`、
`test-windows`、`test-macos`、`test-race` 五项检查全部通过才能合并。
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pull requests previously skipped Go race detection, allowing concurrency regressions to reach master. Run
test-raceon every PR and require it alongside lint, Linux, Windows, and macOS checks before merging.Use
task test:goin the race job to retain the CLI build and Go E2E coverage while avoiding duplicate Dashboard tests, which remain covered by the existing test jobs. Update the contributor guidance to document all five required checks.Validation
task pre-pushpassed, including Go race tests and Dashboard checks.-racesuites, and E2E tests executed.