Skip to content

Lift certifi past PYSEC-2026-4320; README says the canary runs weekly - #15

Merged
jehrr merged 1 commit into
mainfrom
fix/certifi-advisory-canary-wording
Nov 5, 2026
Merged

jehrr merged 1 commit into
mainfrom
fix/certifi-advisory-canary-wording

Conversation

@jehrr

@jehrr jehrr commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Problem

  • The audit workflow has been red on main since certifi 2026.7.22 (pinned in every lock) gained PYSEC-2026-4320, fixed in 2026.10.18. Reproduced locally on 2026-11-05 at 4283b6b: all five locks fail on certifi; the CI-only lock also reports advisories against filelock 4.0.6.
  • The README testing section said the canary "runs one real 3-page scrape a day"; canary.yml has run weekly (Mondays 06:23 UTC) since 2026-10-16.

Change

  • All locks regenerated with the uv command in their headers, with --upgrade-package certifi --upgrade-package filelock so nothing else moves: certifi → 2026.10.23 everywhere; in .github/requirements-ci.lock filelock → 4.2.9 (Python ≥3.11) / 4.1.0 (3.10). No .txt floors changed.
  • README: the testing section now says weekly (Mondays, plus on demand). The status paragraph's dated history (0 rows from 2026-09-29 until the 2026-10-15 release) now says the canary was daily at the time, rather than implying it still is.
  • CHANGELOG under [Unreleased].

Evidence (2026-11-05, local, Python 3.13)

  • pip-audit --require-hashes --disable-pip on requirements, playwright, selenium and CI locks: no known vulnerabilities; puppeteer lock: none beyond the seven urllib3 1.x IDs the workflow already ignores.
  • Fresh venv from the CI lock: compileall, smoke_test.py, pytest, .github/ci_checks.py --all pass.
  • Separate venvs from each engine lock (playwright, selenium, puppeteer): driver import, smoke_test.py and --help pass; certifi 2026.10.23 installed in each.
  • No live scrape: the change touches only dependency pins and documentation.

🤖 Generated with Claude Code

certifi 2026.7.22 in every lock had the audit job red on main. All
locks regenerated with the documented uv command, upgrading only
certifi (to 2026.10.23) and, in the CI-only lock, filelock. The README
testing section still described the canary as daily; it has run on
Mondays since 2026-10-16.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jehrr
jehrr merged commit b176941 into main Nov 5, 2026
7 checks passed
@jehrr
jehrr deleted the fix/certifi-advisory-canary-wording branch November 5, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant