Write the performance results JSON from the test, as common-ci expects - #136
Merged
Merged
Conversation
The Java performance adapter in common-ci now hands the test a file path and expects the test to write the results JSON itself. ShareUsageOverheadTests records both overheads and writes them out at the end of the class. The scraping block in ci/run-performance-tests.ps1 goes, since the common script publishes the file on its own.
justadreamer
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: 51Degrees/common-ci#230 changed the Java performance adapter.
java/run-performance-tests.ps1now passes-Dfiftyone.performance.json=<file>to Maven and expects the test itself to write the results JSON, which it then validates and publishes withsteps/publish-performance-results.ps1. It no longer copies the surefire output intotest-results/performance-summary, andREPO_SCRIPTS.mdnow says a repository script must not scrape a figure from console output.ShareUsageOverheadTestswrote no such file, so every leg of the nightly has failed on the performance step since 2026-09-15 with "The performance example did not produce 'results_.json'".What changes
ShareUsageOverheadTestsrecords both overheads and, in@AfterAll, writes them to the file named byfiftyone.performance.json. When the property is not set, as in local runs and the unit-test step, it writes nothing.ShareUsageOverhead_SingleEvidence_msandShareUsageOverhead_HundredEvidence_msare unchanged, so the graph history stays continuous.ci/run-performance-tests.ps1only delegates to the common script now. The scraping block was dead: the common script exits before reaching it, and publishing happens there.How it was verified
Ran
pipeline-java/ci/run-performance-tests.ps1from a checkout of common-ci main, laid out the way the workflow does it. Before the change it fails with the same message as the nightly. After it, the common script printsPublished 2 metric(s)and exits 0, and the test class still passes when run without the property.