Native InnerTube player extraction, scrub preview and fullscreen gesture pass - #1077
Merged
Merged
Conversation
…ken no client can use
…t from the lockup view model
…and live metadata
… caption-pairing fields the player response already returns
…caption is refused
…ack the user picked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #1068
Closes #1057
Follows up on #1029
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest— 2003 tests, 0 failures:app:compileFossDebugKotlin,spotlessCheckTest device and Android version: Poco X6 Pro, Android 16, HyperOS 3.0.9.0
Screenshots or recordings
To attach: scrub filmstrip and preview box, the rewatch heatmap, and the portrait-fullscreen top read-outs.
Risk and compatibility