Skip to content

Add docstrings to all Python functions in esm1p6_ancil - #161

Open
paul-leopardi wants to merge 1 commit into
166-scen7-l-ln-and-mlfrom
160-draft-doc
Open

paul-leopardi wants to merge 1 commit into
166-scen7-l-ln-and-mlfrom
160-draft-doc

Conversation

@paul-leopardi

Copy link
Copy Markdown
Collaborator

Closes #160
The draft documentation was produced using Google Gemni 3.8 Flash

@paul-leopardi
paul-leopardi added this pull request to stack #158 September 25, 2026 02:51
@read-the-docs-community

read-the-docs-community Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CMIP7-Input | 🛠️ Build #35104853 | 📁 Comparing 58e1ca0 against latest (d1cfb65)

  🔍 Preview build  

2 files changed
± 404.html
± index.html

@paul-leopardi
paul-leopardi marked this pull request as draft September 28, 2026 04:30

@atteggiani atteggiani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @paul-leopardi for working on this documentation update.

I think the overall changes could be classified in two main categories: docstrings changes (or in general any documentation/comment added directly in the source code) and documentation changes.

First, I would separate these changes in two different PRs, as they can be reviewed independently (and this makes it easier to review the documentation changes without having the visual clutter of all changed python code). Therefore, I would keep only the docstrings changes in this PR.

Docstrings changes

I haven't looked at the docstrings in detail, but I think for the moment it's a good idea to have some docstrings for all the functions, so when we refactor the code we have some help understanding what the function does.
Just noting that these docstrings will likely change when the functions get refactored and integrated in the new python package.

Documentation changes

Any documentation change should be developed on top of #163, which configures documentation according to the current ACCESS-NRI standards.

Also, I am not sure documentation changes are required at this point. The main reason is that the status of the code will change drastically after the refactoring and integration in the new python package. Therefore, documentation will need to be changed accordingly.
Currently this documentation is an "AI snapshot" of what's currently in the repo. I think something like this would be easier with a link to DeepWiki (we could add its badge to the README).

Base automatically changed from 150-scenariomip-ext to main October 6, 2026 05:48
@paul-leopardi
paul-leopardi force-pushed the 160-draft-doc branch 2 times, most recently from 6d1475d to 61533bd Compare October 12, 2026 03:20
@penguian
penguian removed this pull request from stack #158 October 12, 2026 03:27
@penguian
penguian changed the base branch from main to 166-scen7-l-ln-and-ml October 12, 2026 03:27
@penguian
penguian added this pull request to stack #168 October 12, 2026 03:27
@paul-leopardi paul-leopardi changed the title Create task documentation for the ACCESS-ESM1.6 workflow Add docstrings to all Python functions in esm1p6_ancil Oct 12, 2026
@paul-leopardi

Copy link
Copy Markdown
Collaborator Author

Hi Davide, I have revised this pull request to include only the docstring changes and have stacked it onto #167 . The RTD failure is because .readthedocs.yaml is missing in this branch.

@atteggiani atteggiani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @paul-leopardi for only including the docstrings changes.

I haven't properly looked at all of them, but for the reasons mentioned above, I think this is good for now.
Thanks

@paul-leopardi
paul-leopardi marked this pull request as ready for review October 12, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Produce draft documentation describing the current workflow and Python scripts

2 participants