Repository navigation
Index reaction targets with their own axis order - #185
Merged
Merged
Conversation
op_system #250 publishes reactions whose source and target templates have different axes: scalar S->I->R models, axis-less donors depositing into a pinned cell, and templated sources collapsing into an axis-less state. The network compiler registered both templates with full_axes, the source's order, and rejected these with a shape mismatch. Register the target with to_full_axes (falling back to full_axes for older artifacts), and check channel and donor coverage against the source template and destination coverage against the target. Advance the development op_system pins to the head of #250. Refs #184 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #184 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jc-macdonald
force-pushed
the
feat/184-to-full-axes
branch
from
October 2, 2026 23:03
8ac8706 to
24b3bc9
Compare
jc-macdonald
changed the base branch from
feat/182-stochastic-coverage
to
main
October 2, 2026 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #183. It also needs op_system #249 and #250. The development pins point at the head of op_system #250 while those await review. Once they merge, I'll rebase this, retarget it to
main, and move the pins to the merge commits.op_system #250 publishes reactions whose source and target templates have different axes: scalar S→I→R models, axis-less donors depositing into a pinned cell (
I -> X[imm=x1]), and templated sources collapsing into an axis-less state (X[imm] -> R).full_axesis the source's axis order. The compiler registered both templates with it and rejected these reactions with a shape mismatch. op_system now publishes the target's order asto_full_axes.Closes #184.
Behavior
to_baseis registered withto_full_axes. Artifacts without the field fall back tofull_axes.offsets, is checked against the target template.Coverage
to_full_axesproduce the same network as before.Docs
Validation
just ci: 592 core tests passed, 2 skipped. 368 provider tests passed (9 new). Ruff and strict mypy passed for both packages.just docs: strict documentation build passed.Two commits: 271 and 12 changed lines.
🤖 Generated with Claude Code