chore: configure pre-commit hooks and format repository - #467
Open
mbohlool wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces pre-commit hooks to automate code formatting and quality checks using pyink, ruff, pylint, and standard git hygiene checks, alongside minor whitespace and formatting cleanups across several configuration files and scripts. The feedback recommends using the official remote repository hook for pyink instead of a local system hook to ensure consistent, hermetic execution across different environments without requiring manual installation.
mbohlool
force-pushed
the
precommit-setup
branch
2 times, most recently
from
August 25, 2026 23:38
5bea9ad to
887a606
Compare
- Add .pre-commit-config.yaml with trailing-whitespace, end-of-file-fixer, check-yaml, ruff, pyink, and pylint - Update .gitignore to track .pre-commit-config.yaml - Add pre-commit setup and venv instructions to README.md
- Fix duplicate YAML keys in base_xl.yml, base21.yml, and ltx2_video.yml - Auto-format utils/update_dependency_table.py with pyink - Fix trailing whitespace and missing EOF newlines across repository files
mbohlool
force-pushed
the
precommit-setup
branch
from
August 25, 2026 23:40
887a606 to
fda9a95
Compare
entrpn
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
pre-committo the repository to automate code formatting, linting, and git hygiene across commits.Key Changes
Pre-commit Configuration (
.pre-commit-config.yaml):trailing-whitespace,end-of-file-fixer,check-yaml,check-added-large-files, andcheck-merge-conflict.ruff check --fixfor fast Python linting and automatic fixes.--pyink-indentation=2 --line-length=125) for Google Python formatting.pylint --fail-under=7on Python files insrc/maxdiffusionandend_to_endmatching CI criteria.Repository Fixes & Cleanup:
base_xl.yml,base21.yml, andltx2_video.ymlthat were causing YAML parser validation errors..gitignoreto track.pre-commit-config.yamlwhile ignoring.pre-commit-cache/.Documentation (
README.md):Developmentsection with instructions to activate the virtual environment before runningpre-commit install.Verification
pre-commit run --all-filesacross all repository files — all hooks (trailing-whitespace,end-of-file-fixer,check-yaml,check-added-large-files,check-merge-conflict,ruff,pyink) pass cleanly..git/hooks/pre-commit.