Declare direct grid_map_core dependency in grid_map_rviz_plugin - #548
Open
andreolf wants to merge 1 commit into
Open
Declare direct grid_map_core dependency in grid_map_rviz_plugin#548andreolf wants to merge 1 commit into
andreolf wants to merge 1 commit into
Conversation
GridMapVisual includes grid_map_core headers and uses grid_map::GridMap, Position, Index and colorValueToVector directly, but the dependency was only reachable transitively via grid_map_ros. Declare it directly in package.xml and CMake so the dependency contract matches source usage. Fixes ANYbotics#538 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #538
Following the analysis by @Plumezz in #538:
GridMapVisualincludesgrid_map_core/GridMap.hppandgrid_map_core/GridMapMath.hppand usesgrid_map::GridMap,Position,Index, andcolorValueToVectordirectly, butgrid_map_corewas only reachable transitively throughgrid_map_ros.This declares the dependency directly:
package.xml: add<depend>grid_map_core</depend>CMakeLists.txt: addfind_package(grid_map_core REQUIRED)and addgrid_map_coreto thedependencieslistPurely additive —
grid_map_coreis already in the recursive dependency closure, so resolution and build behavior are unchanged; the declared contract now matches source usage.🤖 Generated with Claude Code