Declare direct filters dependency in grid_map_demos - #549
Open
andreolf wants to merge 1 commit into
Open
Conversation
FiltersDemo.hpp and normal_filter_comparison_node.cpp include filters/filter_chain.hpp directly, and CMakeLists.txt already calls find_package(filters REQUIRED), but package.xml only received filters transitively via grid_map_filters. Declare it directly so the package metadata matches source usage. Fixes ANYbotics#537 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #537
Following the analysis by @Plumezz in #537:
FiltersDemo.hppandnormal_filter_comparison_node.cppincludefilters/filter_chain.hppdirectly, andCMakeLists.txtalready callsfind_package(filters REQUIRED)— butpackage.xmlonly receivedfilterstransitively viagrid_map_filters.One-line fix: add
<depend>filters</depend>topackage.xmlso the package metadata matches both the source usage and the existing CMake configuration.🤖 Generated with Claude Code