Skip to content

REPL main panics on spawn/join unwrap #8

Description

@APConduct

Summary

REPL binary currently panics on startup and shutdown because main uses unwrap() for both thread spawn and join.

Reproduction

  1. Trigger an error path in Repl::run().
  2. Start the veld REPL binary.
  3. Observe panic due to unwrap().

Expected

Errors should be surfaced cleanly and process should exit with a controlled error.

Actual

main panics on thread spawn/join unwrap paths.

Proposed fix

Return errors from spawn/join and propagate them from main with VeldError::RuntimeError.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions