Skip to content

Fix typos and spell preemptible consistently - #427

Merged
yury-khrustalev merged 1 commit into
ARM-software:mainfrom
yury-khrustalev:sysvabi64-preemptible-typos
Oct 13, 2026
Merged

Fix typos and spell preemptible consistently#427
yury-khrustalev merged 1 commit into
ARM-software:mainfrom
yury-khrustalev:sysvabi64-preemptible-typos

Conversation

@yury-khrustalev

@yury-khrustalev yury-khrustalev commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Change spelling of 'pre-empt*' to 'preemtp*' (without hyphen) and
also use 'preemptible' instead of occasional use of 'preemptable'.

@stuij

stuij commented Sep 18, 2026

Copy link
Copy Markdown
Member

Regarding pre-emptible and its siblings, in the ABI doc corpus as a whole, the overwhelming variant is with hyphen (87 to 6 apparently), so I would convert the unhyphenated form to hyphenated.

@smithp35

smithp35 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Regarding pre-emptible and its siblings, in the ABI doc corpus as a whole, the overwhelming variant is with hyphen (87 to 6 apparently), so I would convert the unhyphenated form to hyphenated.

I remember using the hyphenated form to match the existing ABI conventions. There is an argument that unhyphenated is more of a US English spelling, so more appropriate, however I think being consistent one way or the other across the ABI is preferable.

@yury-khrustalev
yury-khrustalev force-pushed the sysvabi64-preemptible-typos branch 2 times, most recently from f1cdcec to 6dd6e8f Compare September 22, 2026 10:48
@yury-khrustalev

yury-khrustalev commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Regarding pre-emptible and its siblings, in the ABI doc corpus as a whole, the overwhelming variant is with hyphen (87 to 6 apparently), so I would convert the unhyphenated form to hyphenated.

Thank, I've changed pre-empt* to preempt* across all .rst files. I hope it's more consistent now.

@yury-khrustalev yury-khrustalev changed the title sysvabi64: Fix typos and spell preemptible consistently Fix typos and spell preemptible consistently Sep 22, 2026
smithp35
smithp35 approved these changes Sep 22, 2026
View reviewed changes

@smithp35 smithp35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating all the spellings to be consistent. Please give some time before merging to see if there are any further comments from other reviewers.

@yury-khrustalev
yury-khrustalev force-pushed the sysvabi64-preemptible-typos branch from 6dd6e8f to 5ebb26f Compare October 12, 2026 10:08
@yury-khrustalev
Fix typos and spell preemptible consistently
c10e3cd 
Change spelling of 'pre-empt*' to 'preemtp*' (without hyphen) and
also use 'preemptible' instead of occasional use of 'preemptable'.
@yury-khrustalev
yury-khrustalev force-pushed the sysvabi64-preemptible-typos branch from 5ebb26f to c10e3cd Compare October 12, 2026 10:23
@philgee-oss

philgee-oss commented Oct 12, 2026

Copy link
Copy Markdown

LGTM.

@yury-khrustalev
yury-khrustalev merged commit ec3e2fb into ARM-software:main Oct 13, 2026
1 check passed
@yury-khrustalev
yury-khrustalev deleted the sysvabi64-preemptible-typos branch October 13, 2026 12:54
@yury-khrustalev

yury-khrustalev commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Thank you! Merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smithp35 smithp35 smithp35 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yury-khrustalev @stuij @smithp35 @philgee-oss