Repository navigation
Fix diagrams not rendering correctly - #443
Merged
Merged
Conversation
A number of diagrams across several specs didn't render correctly, fix it by using width instead of scale. Basically scale can be dangerous to use in a number of ways. Width is safer.
smithp35
approved these changes
Oct 23, 2026
smithp35
left a comment
smithp35
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
The rendered diagrams look fine on the view side.
Looking it up scale relates to the proportions of the original image and width relates to the proportions of the document. I've found at least one recommendation to prefer width over scale https://ftc-docs.firstinspires.org/en/latest/contrib/tutorials/make_rst/basic_rst_content/basic_rst_content.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of diagrams across several specs didn't render correctly, fix it by using width instead of scale. Basically scale can be dangerous to use in a number of ways. Width is safer.