fix: SG-44546: Fix annotations always enabled - #1373
Open
eloisebrosseau wants to merge 1 commit into
Open
Conversation
eloisebrosseau
force-pushed
the
fix-annotations-always-enabled
branch
9 times, most recently
from
August 24, 2026 14:30
af500ca to
0d11245
Compare
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
eloisebrosseau
force-pushed
the
fix-annotations-always-enabled
branch
from
August 24, 2026 14:41
0d11245 to
b82b10e
Compare
eloisebrosseau
marked this pull request as ready for review
August 24, 2026 15:00
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
August 24, 2026 15:00
cedrik-fuoco-adsk
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SG-44546: Fix annotations always enabled
Summarize your change.
The new annotation package was updated to match the behaviour of the old one where the mode manager is the one responsible of handling the activation and deactivation instead of having it being active all the time. Methods related to manage not showing the new panel at the same time as the old was was removed since only one package can be loaded at once. Some cleanup was also done to remove mentions of Live Review in annotate_meta_mode.py.
Describe the reason for the change.
The new annotation tool was always enabled instead of being activated and deactivated by the mode manager like the old annotation tool is. This was prevented the normal events for play/pause and playback to go through, and resulted in strokes being drawn on the frames instead.
Describe what you have tested and on which operating system.
Loading a clip with the new annotation panel closed, and clicking on the frames or the timeline to validate that playback was triggered instead of drawing strokes, was tested on macOS.