Repository navigation
ogar-vocab: reserve the 0xFFXX concept block for lance-graph hardcoded behaviour - #365
Merged
Merged
Conversation
Concept 0xFFFF is the left half of lance-graph's hardcoded behaviour lenses (0xFFFF :: 0xF###), registered by lance-graph's DT64 store (D-DT64-7 decisions O2 and O8). HARDCODED_BEHAVIOUR names it, the domain table lists the reserved 0xFFXX block, and a test fails if any CODEBOOK or class_ids::ALL row lands there. ConceptDomain is unchanged (the block still reads Unassigned), so the lance-graph mirror needs no paired change.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 1, 2026 01:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reserves the left-half block
0xFFXXinogar-vocabfor lance-graph's hardcoded behaviour classids (0xFFFF :: 0xF###, D-DT64-7). OGAR never mints a concept there.HARDCODED_BEHAVIOUR: u16 = 0xFFFFandHARDCODED_BEHAVIOUR_DOMAIN = 0xFF, documented as owned by lance-graph-dt64 rather than by this codebook.no_codebook_row_lands_in_the_hardcoded_behaviour_block. It checks four things:CODEBOOKrow and noclass_ids::ALLentry hasid >> 8 == 0xFF;canonical_concept_name(0xFFFF)isNone;canonical_concept_id("hardcoded_behaviour")isNone;canonical_concept_domain(0xFFFF)is stillUnassigned.ConceptDomainis unchanged. The reservation is a guard, not a new domain.Why
The right half
0xF###addresses behaviour lenses (relalgF0__, XLOGF1__, ONNXF2__, TF/TFLiteF3__), and lance-graph-dt64 registers them without asking this codebook. That only stays sound if no OGAR concept can ever land on the same left half.Validation
cargo test -p ogar-vocab: 175 + 6 passed, 1 ignored.cargo clippy -p ogar-vocab --all-targets -- -D warnings: clean.cargo fmt --check: clean.("planted_in_reserved_block", 0xFF01)inCODEBOOKturns the test red withplanted_in_reserved_block (0xff01) landed in the reserved 0xFFXX block. The tree was restored afterwards.A matching guard on the lance-graph contract mirror (
ogar_codebook) follows in a separate lance-graph PR.Generated by Claude Code