Repository navigation
Float the RustCrypto fork pins that their default branch can carry - #375
Merged
Merged
Conversation
Internal pins are prohibited. A [patch] only applies when the fork carries the version crates.io would resolve, so a fork pin can float exactly when its default branch still carries that version: - ecdsa 0.17.0: signatures rev 5595c3b -> master (master is 5595c3b). - ed448-goldilocks 0.14.0-pre.15: elliptic-curves rev f5cb30e -> master (739304e, 45 commits newer, same version). - p256 0.14.0 (ogar-oidc): elliptic-curves rev 739304e -> master. ed448 and p256 now resolve to one elliptic-curves commit. A fresh generate-lockfile reports no unused patch; ogar-oidc, ogar-auth and ogar-encryption tests and clippy -D warnings pass. Still pinned, because the fork's default branch is a semver-incompatible major ahead and floating would silently fall back to crates.io: chacha20poly1305 0.10.1 (master 0.11.0), poly1305 0.8.0 (master 0.9.1), curve25519-dalek 4.1.3 (main 5.0.0), md-5 0.10.6 (master 0.11.0), des 0.8.1 (master 0.9.0). The Cargo.toml comment and docs/UPSTREAM-DEPS.md say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 8, 2026 01:51
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal pins are prohibited. A
[patch]only applies when the fork carries the version crates.io would resolve. So a fork pin can float exactly when its default branch still carries that version.Floated
ecdsa0.17.05595c3bmaster5595c3b, the same commited448-goldilocks0.14.0-pre.15f5cb30emaster739304e: 45 commits newer, same versionp2560.14.0 (ogar-oidc)739304emaster739304e, the same commited448-goldilocksandp256now resolve to one elliptic-curves commit; before this they used two.Still pinned
Each of these forks' default branch is a semver-incompatible major ahead. Floating would silently drop the patch and take the crate from crates.io.
chacha20poly1305master0.11.0poly1305master0.9.1curve25519-dalekmain5.0.0md-5master0.11.0desmaster0.9.0Unpinning these means migrating the consumers, ndarray
encryptionand ogar-auth, to the new majors. TheCargo.tomlcomment anddocs/UPSTREAM-DEPS.mdnow say so.Validation
cargo generate-lockfilereports no unused patch.cargo test -p ogar-oidc -p ogar-auth -p ogar-encryption: all pass (84, 1 ignored).clippy -D warningson the same three crates is clean.Generated by Claude Code