Repository navigation
Float the AdaWorldAPI fork pins on their default branch - #1985
Merged
Merged
Conversation
Internal pins are prohibited, so the egglog, PathMap and ractor pins move to their fork's default branch: - egglog rev 5deaa56 -> main (dr-math-binding-probe, egglog-r2il-probe, xlog-relcomp-probe). main's head is 5deaa56, so all three resolve to the same commit as before, and still name one source. - PathMap rev ef02591 -> master (crepe-plan-probe, mork-pathmap-probe, including its [patch] for MORK). master's head is ef02591. - ractor branch claude/jirak-math-theorems-harvest-rfii13 -> main (cognitive-stack, symbiont). main's one extra commit is the merge of that branch, so the tree is unchanged. All seven manifests resolve with no unused-patch warning. The egglog-r2il-probe comment records the cost the 2026-11-02 pin avoided: a ProofChanged refusal can now come from an egglog change. Not floated, because the fork's default branch does not carry the pinned commits: - crepe branch ccr-d3ce1263-ied9yh (2 commits not on crepe main). - MORK de9312e3 (the stable-build fix; MORK main needs nightly). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 8, 2026 01:53
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal pins are prohibited. This moves every AdaWorldAPI fork pin that the fork's default branch can carry onto that branch.
5deaa56main5deaa56, the same commitef02591masteref02591, the same commit[patch]for MORK)claude/jirak-math-theorems-harvest-rfii13mainf4c474f, the merge of that branch, so the tree is unchangedEvery crate that links egglog still names one source, which was the point of the 2026-11-02 one-commit pin. The egglog-r2il-probe comment records the cost that pin avoided: a
ReplayRefusal::ProofChangedcan now come from an egglog change, so read it against egglogmain's log first.Not floated
These pins cannot float, because the fork's default branch does not carry the pinned commits:
ccr-d3ce1263-ied9yh(crepe-plan-probe, dir-rmap-probe). It has 2 commits that crepemainlacks.de9312e3(mork-pathmap-probe). This is branchccr-9f3b8075-74u47l-stable, which makesnightlya feature so the crate builds on stable. MORKmainneeds nightly.Unpinning either means landing those commits on the fork's default branch first.
xlog(BrainyBlaze/xlog) is not an AdaWorldAPI repo and keeps its rev.Validation
cargo metadataresolves all seven changed manifests, with no unused-patch warning.Generated by Claude Code