Repository navigation
D-CODEGRAPH-RECON-1: Codegraph over real Charon stores, Mermaid reconstruction, review evidence packet - #2000
Conversation
…s empty Prints callers, callees, impact and references with their grade, prints refusals verbatim, and adds an UNKNOWN external-callers-unobserved line for any PUBLIC symbol plus the files the store observed. Measured on a Charon store of lance-graph-dt64: 261 of 370 public symbols otherwise return an empty impact although their callers live in other crates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
… process Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
…corpus and seed list recon.py rebuilds a diagram from a ruff_charon store only, scores the curated corpus' call edges against compiler call sites, overlays labelled human rows, and emits a read-only review evidence packet. --self-test holds the eleven negatives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
…possible dispatch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
…Mermaid, recall scores, evidence packets, report draft Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
…ETHOD, body UNKNOWN) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
… board entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6c6e4ec7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…atch to implementations A caller reached only through a stale edge is no longer confirmed; it is listed under affected_symbols.stale and flags dependency_evidence_stale. possible now joins IMPLEMENTS to MAY_DISPATCH, as Codegraph::callers does, and propagates through callers. An edge from a missing source file is drawn as MISSING_SOURCE, never as a verified edge. Addresses review on #2000. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
This probe tests whether an agent can get source-backed answers about the DT64 / R2IL / RBAC subsystems from compiler facts. Those answers cover what exists, what calls what, impact, and what is unknown. Board: EXO-229 (intake), EXO-230 (navigation).
Changes
crates/lance-graph-codegraph/examples/cg_query.rs: a new read-only command-line tool over Codegraph (symbols,callers,callees,impact,refs,sweep).PUBLICsymbol gets anUNKNOWN external-callers-unobservedline, and every answer lists the files the store observed..claude/probes/2026-11-11-codegraph-recon-1/:corpus.tsv: 444 relationships from.mermaid/pages 03, 05 and 06, each verified against source.recon.py: builds the machine-recovered diagram from store rows only, scores recall, writes the reconciled diagram and the evidence packet, and carries 15 negative tests.REPORT.md..codegraph/coverage.tsvis regenerated for the new example, and there is a board entry.Findings (all measured; details in REPORT.md)
impact+callersover all of them takes 1.2 s with 0 refusals.closure_wide.impactreturns an empty set for public symbols whose callers are in other crates. On dt64 this is 261 of 370 public symbols, includingBindStore::admitandmethod_ref.#[cfg(test)]modules, and counts 6,280 constructions as calls.ReviewEvidencePacketprototype for a change toLaneBinding::check, using the crai-rs fields and axes. It holds evidence, not a verdict.Review fixes
Codex raised three findings in its review. Each now has a test that failed first and goes red again when the fix is disabled:
possiblenow joinsIMPLEMENTStoMAY_DISPATCH, asCodegraph::callersdoes (test 12).Reproduction
The documented Charon and ruff_charon commands were re-run from scratch into a fresh directory.
machine-recovered.mmd,reconciled.mmdandscore.tsvregenerate byte-identical.Open
Codegraph::impact_reportadditively.Codegraph::impactis unchanged (D-CODEGRAPH-RECON-2).Checks
cargo clippy --release --example cg_query -- -D warningsandcargo fmt -- --check(incrates/lance-graph-codegraph)python3 .claude/probes/2026-11-11-codegraph-recon-1/recon.py --self-test: 15 tests, each disable-verified redpython3 .claude/tools/codegraph_index.py --check: current🤖 Generated with Claude Code
https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p