Repository navigation
dt64: lane binding refuses a predicate change at a bound position (D-DRDT-SPLIT-1 S8) - #2021
Merged
Merged
Conversation
bind_lanes records the predicate IRI each bound position resolved to; the
hot check compares it after lane_of and refuses with PredicateChanged
{ class, field } when a view reorder put another predicate at that
position. Label-only renames and reorders outside the bound positions
still admit. No hashing on the hot path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
November 11, 2026 19:57
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S8 of
dr-widefieldmask-dt-classview-v1.md§5, which closes D-DT64-7 L5d. Before this change, the hotLaneBinding::checkcould not detect a view reorder under a positional source: the pinned testfinding_the_hot_check_does_not_see_a_view_reorder_under_a_positional_sourcerecorded the gap.Change
bind_lanesnow records the predicate IRI each bound position resolved to.lane_of. When a reorder puts a different predicate at a bound position, the check refuses with the newLaneRefusal::PredicateChanged { class, field }.Existing behaviour that changed: exactly the case the pinned finding recorded. That test is replaced by
a_view_reorder_at_a_bound_position_is_refused_under_a_positional_source.Evidence
cargo test -p lance-graph-dt64: all suites pass (59 + 36 + 20 + 2). clippy-D warningsand fmt are clean.cargo run --release --example lane_check_costmeasures the whole check (currency,lane_ofand the predicate compare):The refused path at k = 1 costs 34.65 ns.
Not verified
lance-graph-rbac) builds on this and follows in its own PR.Generated by Claude Code