Repository navigation
test(miri): skip u9_head_to_head's flush-bound run under miri - #411
Merged
Merged
Conversation
Follow-up to #410. A local miri run of the three integration files after #410 showed u9_head_to_head still over 40 minutes: worst_case_runs_cross_the_flush_bounds_exactly runs 3 * B_FLUSH_BLOCKS + 5 all-255 blocks, the same shape as the flush-bound runs #410 already skips under miri (its name did not match the earlier search). It would also hit the new 20-minute per-test limit on CI. It now carries the same #[cfg_attr(miri, ignore = "...")]; the native test jobs still run it. Under miri: u9_head_to_head 3 passed, 2 ignored, 10 s wall (was > 2400 s); pof_antennas 42 passed, 1 ignored, 865 s; u9_abacus 11 passed, 9 ignored, 232 s (wall times include compiling). A sweep of tests/, src/ and examples/ for `*_FLUSH_BLOCKS` runs finds no other unskipped one. Native: u9_head_to_head 5 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMQJzQD5KvNm8BtbsWG
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #410.
A local miri run of the three integration files after #410 showed
u9_head_to_headstill running past 40 minutes. The cause isworst_case_runs_cross_the_flush_bounds_exactly, which runs 3 ×B_FLUSH_BLOCKS+ 5 all-255 blocks. That is the same shape as the flush-bound runs #410 already skips under miri; its name just didn't match my earlier search. It would also hit the new 20-minute per-test limit on CI. It now carries the same#[cfg_attr(miri, ignore = "...")], and the native test jobs still run it.Measured under miri (wall time, compile included)
u9_head_to_headpof_antennasu9_abacusA search of
tests/,src/andexamples/for*_FLUSH_BLOCKSruns finds no other run without the skip. Natively,u9_head_to_headhas 5 passed.Generated by Claude Code