Repository navigation
ci(miri): shard the run across eight jobs - #412
Merged
Merged
Conversation
Under Miri each test runs as its own interpreted process, about 30 s minimum each (measured locally: 33-39 s wall for single trivial tests). The ~1400 selected tests take 4-5 hours serial; the 2026-11-05 master run was cancelled at the 2-hour job cap after 590 tests. The job now runs as an eight-way matrix, each shard passing --partition count:K/8 to nextest via MIRI_PARTITION. The script runs the full suite when the variable is unset. Coverage is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMQJzQD5KvNm8BtbsWG
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 6, 2026 01:55
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The miri job on master is cancelled at its 2-hour cap. Run 42127372661 got through 590 of about 1400 tests before the cap hit. Under Miri each test runs as its own interpreted process, which costs about 30 s minimum per test. Measured locally, two trivial tests took 33 s and 39 s wall each. At that rate the full suite needs 4–5 hours on one runner.
Change
ci.yaml§ miri: the job now runs as an eight-shard matrix (miri/1…miri/8,fail-fast: false). Each shard keeps the 120-minute cap.scripts/miri-tests.sh: passes--partition "$MIRI_PARTITION"to nextest when the variable is set. Unset, it runs the full suite as before.Coverage is unchanged: same filter, same features, same per-test limit. The
conclusionjob already needsmiri, which covers all shards.Verification
The script passes
sh -n. The sharded run itself only happens on push to master, so the first real check is the post-merge run.Generated by Claude Code