Repository navigation
Float x448 on the elliptic-curves default branch - #416
Merged
Merged
Conversation
The x448 dependency was pinned to rev 739304e, the commit `master` of AdaWorldAPI/elliptic-curves currently points at. Consumers (OGAR, report-rs) already take ed448-goldilocks and p256 from the same repository on `master`, so the pin would put a second copy of the curve crates in their graph as soon as `master` moves. Internal AdaWorldAPI pins are prohibited; it now floats. Resolution is unchanged today (branch=master#739304e). cargo test, clippy -D warnings and fmt pass for -p encryption. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 8, 2026 07:35
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates/encryptionpinnedx448to rev739304eof AdaWorldAPI/elliptic-curves. That is the commitmasterpoints at today. OGAR and report-rs already takeed448-goldilocksandp256from the same repository onmaster, so the pin would put a second copy of the curve crates in their dependency graph as soon asmastermoves. Internal AdaWorldAPI pins are prohibited;x448now floats onmaster.The resolution today is unchanged:
cargo treeshowselliptic-curves?branch=master#739304e0.Validation, all for
-p encryption:cargo test: 46 and 13 tests pass.cargo clippy --all-targets -- -D warnings: clean.cargo fmt --check: clean.Not changed:
crates/burnpinsburn-backend,burn-stdandburn-irto rev9b2b671. That commit is not on burn'smain, which is 429 commits ahead of it, so those pins cannot float until the commit is merged intomainor the pin moves to a branch that carries it.Generated by Claude Code