Repository navigation
Re-apply fork work as one squash on top of sonos/tract main - #10
Merged
Merged
Conversation
…ract main Our fork-only changes since the last shared commit 7ef965c, replayed as one commit on upstream 7e8be2f: ndarray SIMD/GEMM/AMX-BF16 pilots in linalg, the CI lint gate, and the .claude knowledge files. Lock files stay deleted, and both deny.toml files keep upstream's new skip entries plus our allowed git sources. Full history is on backup/main-pre-upstream-sync-2026-10-29. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMjKnig6MXTd41Lf2v
Upstream renamed Tensor::try_as_plain_mut to try_as_plain_ram_mut, so the AMX native packer uses the new name. The toolchain moves to 1.99.0 because the AdaWorldAPI ndarray fork now requires it and 1.98.1 no longer resolves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMjKnig6MXTd41Lf2v
AdaWorldAPI
marked this pull request as ready for review
October 29, 2026 07:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch carries the fork's own work (105 commits from PRs #1–#9) as one commit on top of the current
sonos/tractmain (7e8be2f), plus a small follow-up so it builds there.Intended order:
mainbecomes exactlysonos/tractmain.The old history stays on
backup/main-pre-upstream-sync-2026-10-29andbackup/main-pre-upstream-sync-2026-10-29-b(both at6ce7c91).Commits:
e512dfe: a squash of all fork changes since the last shared commit (7ef965c). It covers the same 48 files as the fork's diff. Conflicts were resolved like this:Cargo.lockfiles stay deleted (fork convention).deny.tomlfiles keep upstream's newskipentries plus our[sources] allow-gitlist.aeafcd3:try_as_plain_mut→try_as_plain_ram_mut, because upstream renamed the method.main).Verified locally:
cargo fmt --all --checkpasses.cargo check --all-targetson the default members passes.cargo test --release -p tract-linalg --lib: 4804 passed, 0 failed.Known red: the fork's lint gate (
cargo clippy --all-targets -- -D warnings) fails on Rust 1.99 because of upstream code, not ours:redundant_field_namesfindings intract-coreand other crates, coming fromderive-newexpansions.chunks_exact/useless_conversion/too_many_argumentsfindings.Upstream's CI does not deny clippy warnings, so these are new to us. Fixing them is a separate decision.
Generated by Claude Code