Skip to content

fix: inline title validation in TaskEditDialog #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamJ merged 1 commit into from
Oct 19, 2026
Merged

fix: inline title validation in TaskEditDialog #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/components/TaskEditDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { Clock, Save } from 'lucide-react';
import { Task } from '@/contexts/TimeTrackingContext';
import { useTimeTracking } from '@/hooks/useTimeTracking';
import { formatTime, formatDate } from '@/utils/timeUtil';
import { toast } from '@/hooks/use-toast';

interface TaskEditDialogProps {
task: Task;
Expand Down Expand Up @@ -61,6 +60,7 @@ export const TaskEditDialog: React.FC<TaskEditDialogProps> = ({
});

const [hasChanges, setHasChanges] = useState(false);
const [titleTouched, setTitleTouched] = useState(false);

// Reset form when task changes or dialog opens
useEffect(() => {
Expand All @@ -81,6 +81,7 @@ export const TaskEditDialog: React.FC<TaskEditDialogProps> = ({
});

setHasChanges(false);
setTitleTouched(false);
}
}, [task, projects, isOpen]);

Expand Down Expand Up @@ -150,13 +151,8 @@ export const TaskEditDialog: React.FC<TaskEditDialogProps> = ({
};

const handleSave = () => {
// Validate required fields
if (!formData.title.trim()) {
toast({
title: 'Title required',
description: 'Please enter a task title before saving.',
variant: 'destructive'
});
setTitleTouched(true);
return;
}

Expand Down Expand Up @@ -205,6 +201,8 @@ export const TaskEditDialog: React.FC<TaskEditDialogProps> = ({
onClose();
};

const titleError = titleTouched && !formData.title.trim() ? 'Task title is required.' : '';

return (
<Dialog open={isOpen} onOpenChange={onClose}>
<DialogContent className="max-w-2xl max-h-[90vh] flex flex-col overflow-hidden">
Expand Down Expand Up @@ -243,9 +241,17 @@ export const TaskEditDialog: React.FC<TaskEditDialogProps> = ({
title: e.target.value
}))
}
onBlur={() => setTitleTouched(true)}
placeholder="Enter task title"
aria-required="true"
aria-invalid={!!titleError}
aria-describedby={titleError ? 'task-edit-title-error' : undefined}
/>
{titleError && (
<p id="task-edit-title-error" className="text-sm text-destructive" role="alert">
{titleError}
</p>
)}
</div>

<div>
Expand Down
Loading