Repository navigation
fix: CLI and verification docs match the code - #105
Merged
Merged
Conversation
No Run verification button exists; affitor setup stripe cannot connect Stripe (dashboard only); onboard and whoami --json exit 1 on a negative outcome; program keys start with aff_. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Six claims in the Stripe/onboarding docs, checked against
origin/mainof affiliate-cms (87a36eab), Affitor/cli (ba97fd6, 0.4.2) and affiliate-dashboard (700cd90). This PR fixes the doc bugs. The CLI code bug is fixed in Affitor/cli#35.affitor test"/api/tracking/run-verificationproxy (onlysrc/pages/api/tracking/run-verification/[programId].tsandutils/request.ts:2602).Settings/index.tsx:337-339,461-463: "Synthetic verification is the agent's path only; the human just clicks Go Live". CMS go-live lean gate = profile + economics (affiliate-program.ts:337-344).affitor testsends one event (cli/src/commands/test.ts:53-56); the chain isonboard/ MCPaffitor_run_verification(api-client.ts:168-191,mcp/src/index.ts:313-326)brand/tracking/testing-integration,quickstart-integration,quickstart/payouts,quickstart/define-commissionaffitor setup stripecreates a webhook at<api-url>/webhooks/stripe/<program-id>POST /api/webhook-distributor/stripe(webhook-distributor/routes/custom-routes.ts:6); CLI save endpoint answers 410 (cli/controllers/cli.ts:368-382); token exchange needs Affitor's platform secret (cli stripe-oauth.ts:53-57)brand/cli/commandssetup stripe section + error tables,brand/cli/quickstart,api-reference/agent-integration: connect Stripe in the dashboardinvoice.paid, CMS handlesinvoice.payment_succeededcli types.ts:199-206vswebhook-distributor.ts:787; noinvoice.paidhandler anywhere in CMSsrc/), but the CLI flow never completes (row 2), so no endpoint ever fed renewals. Dashboard-connected Stripe goes through the platform webhook, which handlesinvoice.payment_succeededinvoice.paidmentions in the self-hosted guides (integrations/stripe,fastify) are about the brand's own handler and are correctonboardandwhoami --jsonreport a negative outcome with exit 0onboard.ts:129-131sets exit 1 unlessintegration_verified;whoami.ts:16-19exits 1 when logged out (CHANGELOG 0.4.2)brand/cli/commands: exit table, whoami line, onboard sectionprogram_idis not required:resolveCustomerPartnertakes it as optional and falls back to email_hash / stripe_customer_id / customer_key (webhook-distributor.ts:966-1130,1304-1333). Docs already call metadata "recommended" (integrations/stripe.mdx:105). See note below on dashboard /pricingaffitor_aff_(affiliate-program/services/affiliate-program.ts:13-19);affitor_is legacy, still accepted (middlewares/agent-scope.ts:40-46)brand/cli/commandsonboard example,brand/cli/quickstartJSON exampleNote on 5 (dashboard copy, not changed here): /pricing says "nothing to wire into your checkout" / "zero-code". Without checkout metadata, a Connect sale is matched only via a stored identity. The usual one is the email hash. A browser
signup()under the defaultlead_auth: server_requiredis provisional and writes no identity (affiliate-lead-event.ts:53-66; schema defaultserver_required). So the email path needs a server-side lead. Flagged for a separate decision.Verification
npm run buildpassnode scripts/check-agent-surface.mjsPASS🤖 Generated with Claude Code