Repository navigation
test: mindrecord androidTest를 JVM으로 이동 (#1090) - #1353
Merged
OnlyReadOneBook merged 4 commits intoAug 28, 2026
Merged
OnlyReadOneBook merged 4 commits into
OnlyReadOneBook merged 4 commits into
Conversation
This was referenced Aug 28, 2026
Sadturtleman
approved these changes
Aug 28, 2026
OnlyReadOneBook
merged commit Aug 28, 2026
a9ca273
into
fix/964-write-failure-telemetry
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Issues
📎 Work Description
MindRecordFlowAndroidTest·MindRecordLifecycleAndroidTest의 7개 Compose 시나리오를 mindrecord presentation 모듈 JVMsrc/test로 이동했습니다.FailureArtifactRule을 제거했습니다.RecordingErrorReporterstage 검증과 ViewModel 생성자 계약, 기존 payload·repository 호출·UI assertion·5초 timeout을 보존했습니다.UserRepositoryallowlist를 feature-local helper로 복원해 예기치 않은 repository 호출은 계속 실패하도록 했습니다.w360dp-h800dp-xhdpiviewport에서 원본performClick()을 그대로 실행하고 상태 재구성 완료를 명시적으로 기다립니다.스택 관계
fix/964-write-failure-telemetry(PR feat(mindrecord): 작성 실패를 텔레메트리에 남긴다 — 쓰기 승격 3종 (#964) #1278)🧪 CI Test Plan
{ "androidTest": { "mode": "selected", "reason": "mindrecord feature-local Compose 계측 소스를 JVM으로 이동했으므로, app에 남는 mindrecord home의 로딩·재시도·성공 경계를 API 30에서 선택 검증합니다.", "tests": [ { "path": "app/src/androidTest/java/com/afternote/afternote_fe/TimeLetterMindRecordCompletionAndroidTest.kt", "selector": "com.afternote.afternote_fe.TimeLetterMindRecordCompletionAndroidTest#mindRecordHome_dailyQuestionLoadingEmptyAndErrorRetrySuccess_areRendered", "device": "api30" } ] } }검증:
:feature:mindrecord:presentation:testDebugUnitTest(7/7, failures/errors/skipped 0):feature:mindrecord:presentation:ktlintCheck:feature:mindrecord:presentation:koverXmlReportCi:konsist:test:app:compileDebugAndroidTestKotlin -x :app:processDebugGoogleServicesgit diff --check📷 Screenshot
💬 To Reviewers
TimeLetterMindRecordCompletionAndroidTest는 timeletter 3개·mindrecord 5개로 분리 가능하지만, 현재 PR #1340과 #1278이 서로 다른 스택에서 같은 파일을 수정 중이므로 이 PR에서는 #1090에 명시된 두 파일만 이동했습니다.