Repository navigation
fix(receiver): 수신자 홈 헤더에서 회원 설정 진입점을 내린다 (#613) #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a45f0ca
fix(receiver): 수신자 홈 헤더에서 회원 설정 진입점을 내린다
Sadturtleman 4b2c1e4
fix(receiver): 계측의 ReceiverHomeActions 생성부에서도 설정 콜백을 걷는다
Sadturtleman f7ee470
test: update screenshot baselines in CI
github-actions[bot] 68c87a5
Merge branch 'develop' into fix/613-receiver-home-setting-entry
Sadturtleman e8b6424
Merge branch 'develop' into fix/613-receiver-home-setting-entry
Sadturtleman 260be9c
Merge branch 'develop' into fix/613-receiver-home-setting-entry
Sadturtleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-1.25 KB
(94%)
...erHomeScreenScreenshotTestKt/receiverHomeScreenLoadingScreenshot_748aa731_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.22 KB
(99%)
...creenScreenshotTestKt/receiverHomeScreenPartialFailureScreenshot_748aa731_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.15 KB
(100%)
...erHomeScreenScreenshotTestKt/receiverHomeScreenSuccessScreenshot_748aa731_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor] 머지를 막지 않습니다 — 다만 이 단언은 «헤더» 가 아니라 화면 전체를 셉니다.
지금 통과하는 이유는
ReceiverHomeScreen의ReceiverHomeUiState.Loading -> { }가 본문을 아무것도 그리지 않기 때문입니다. 즉 헤더만 남은 상태라 우연히 이름과 결과가 맞아떨어집니다. 두 방향으로 어긋납니다.Success상태에서만 톱니가 되살아나는 회귀는 못 잡습니다 — 두 테스트 다Loading만 태웁니다. 지금 코드는 상태와 무관하게 같은HomeTopBar한 곳이라 실질 구멍은 아니지만, 이 테스트가 막겠다고 적은 «이름을 모르는 새 아이콘» 은 그 헤더가 상태별로 갈리는 순간 빠져나갑니다.HomeTopBar에 이미PROFILE_ICON_TEST_TAG같은 앵커를 쓰는 선례가 있으니, 탑바 서브트리로 좁히거나(onNode(hasTestTag(...)).onChildren()) 최소한Success상태도 함께 태우면 이름과 실체가 맞습니다.