Repository navigation
feat(setting): 1:1 문의 화면 구현 (#784) #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
...tation/src/main/kotlin/com/afternote/feature/setting/presentation/model/InquiryUiModel.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.afternote.feature.setting.presentation.model | ||
|
|
||
| enum class InquiryStatus { RECEIVED, ANSWERED } | ||
|
|
||
| data class InquiryUiModel( | ||
| val id: Long, | ||
| val status: InquiryStatus, | ||
| val date: String, | ||
| val title: String, | ||
| val content: String, | ||
| val answer: String?, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[normal] 상세 라우트가 도달 불가인 채로 남았습니다.
InquiryListRoute가 항상emptyList()를 넘기므로(:196) 목록의LazyColumn분기가 그려지지 않고,onInquiryClick = actions::onNavigateToInquiryDetail로 배선은 돼 있어도 발화할 경로가 없습니다.도달 불가 셸 자체를 지우자는 얘기는 아닙니다. 바로 위
NoticeRoute도notices = emptyList()로 이미 머지돼 있고, 지우면#784가 요구한 화면 3종 중 하나가 없어집니다.좁은 문제는 여기입니다.
SettingRoute.kt:61이inquiryId: Long을 요구하는데 이 줄은 그 인자를 한 번도 읽지 않고 무조건inquiry = null을 넘깁니다. 조회 API 가 생기면 반드시 고쳐야 하는 자리라 TODO 나 후속 이슈 번호를 남겨 두는 편이 낫습니다.