Repository navigation
refactor(setting): 수신자 저장 정책을 UseCase로 분리 (#1691) - #2124
Merged
Merged
Conversation
OnlyReadOneBook
added this pull request to stack #2125
September 20, 2026 13:07
This was referenced Sep 20, 2026
Sadturtleman
approved these changes
Sep 25, 2026
…es' into refactor/1691-setting-save-usecases
Contributor
|
형제 충돌이 해소됐다 — 지금은 이 PR 과 같은 파일을 서로 다르게 고친 열린 PR 이 없다 (#1750). |
OnlyReadOneBook
removed this pull request from stack #2125
September 27, 2026 04:44
OnlyReadOneBook
changed the base branch from
refactor/1429-setting-repositories
to
refactor/2179-setting-editors-mvi
September 27, 2026 04:44
OnlyReadOneBook
added this pull request to stack #2181
September 27, 2026 04:44
…etting-save-usecases
Contributor
|
이 PR 은
|
…i' into tmp/2124-conflict # Conflicts: # feature/setting/presentation/src/main/kotlin/com/afternote/feature/setting/presentation/delivery/DeliveryConditionViewModel.kt # feature/setting/presentation/src/main/kotlin/com/afternote/feature/setting/presentation/receiver/ReceiverEditViewModel.kt
…etting-save-usecases
OnlyReadOneBook
removed this pull request from stack #2181
October 1, 2026 11:22
OnlyReadOneBook
added this pull request to stack #2228
October 1, 2026 11:22
Sadturtleman
approved these changes
Oct 4, 2026
Sadturtleman
left a comment
Collaborator
There was a problem hiding this comment.
MVI 선행 위로 옮긴 UseCase 소비가 기존 결과 분기와 취소 전파를 그대로 유지하는 것을 확인했습니다. 최신 head 기준으로 다시 승인합니다.
This was referenced Oct 5, 2026
…ing-save-usecases
Sadturtleman
approved these changes
Oct 5, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
핵심 파일:
UpdateReceiverInfoUseCase.kt,UpdateTimeLetterDeliveryConditionUseCase.kt,ReceiverEditViewModel.kt,DeliveryConditionViewModel.kt.Closes #1691
수신자 기본정보 뒤 인사말을 저장하는 순서와 타임레터 전달조건 갱신 정책을 setting domain UseCase로 분리했습니다. 기본정보 실패와 인사말 부분 실패를 구분하고 두 쓰기 사이의 취소, 기존 Throwable 포착 범위와 조건 상태·시각 정보를 보존합니다.
실제 base는 #2180의
refactor/2179-setting-editors-mvi입니다. Nav3 assisted route와 MVI 입력·상태·신호 계약을 그대로 소비하며 UseCase의 결과만 reducer event로 전달합니다. #2123 → #2173 → #2180 → 이 PR 순서로 검토합니다.검증: domain 저장 정책 회귀 테스트 10개와 설정 단위 테스트 87개, 설정 ktlint 및 앱 main/androidTest 컴파일을 통과했습니다. 기존 두 Throwable 포착 변이에서 회귀 테스트가 실패하는 것도 확인된 범위입니다.
🧪 CI Test Plan
{ "androidTest": { "mode": "none", "reason": "JVM domain 저장 정책 추출과 기존 MVI ViewModel의 UseCase 소비 변경입니다. 저장 순서·부분 실패·취소·조건 보존은 domain 및 presentation 단위 테스트로, Hilt 연결은 앱 컴파일로 검증합니다. 화면과 네비게이션 동작은 base 그대로입니다.", "tests": [] } }