Repository navigation
fix(core,app): Nav3 화면의 predictive back 배경을 불투명하게 유지한다 (#2145) - #2153
Merged
Merged
Conversation
Contributor
|
형제 충돌이 해소됐다 — 지금은 이 PR 과 같은 파일을 서로 다르게 고친 열린 PR 이 없다 (#1750). |
This was referenced Sep 23, 2026
Collaborator
Author
Collaborator
Author
펜 버튼 겹침 판정 (2026-09-23)위 코멘트에 적은 "상세에서 뒤로 끌 때 뒤 목록의 펜 버튼이 앞 화면 우하단 위에 겹쳐 그려진다" 는 착시였습니다. 펜 버튼은 앞 화면 아래에 그려집니다.
|
Sadturtleman
approved these changes
Sep 25, 2026
This was referenced Sep 26, 2026
… fix/2145-predictive-back-opaque-entry # Conflicts: # app/src/main/java/com/afternote/afternote_fe/navigation/AppNavigation.kt
OnlyReadOneBook
changed the base branch from
develop
to
refactor/1695-setting-nav3
September 27, 2026 04:48
… fix/2145-predictive-back-opaque-entry
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




먼저 볼 파일:
core/ui/.../navigation/NavDestinationSurface.kt,core/ui/.../navigation/FeatureNavDisplay.kt,core/ui/src/test/.../FeatureNavDisplayTest.kt입니다.Closes #2145
Refs #1695
predictive back 진행 중 축소된 앞 화면의 빈 영역으로 뒤 화면 글자가 비치던 문제를 고칩니다. 공통 Nav3 entry 데코레이터가 루트 셸과 같은 불투명 배경을 그리며, 설정을 포함한 Nav3 로컬 스택에 적용됩니다. 루트 Scaffold도 같은 배경값을 사용합니다.
실제 base는 #2173의
refactor/1695-setting-nav3입니다. 설정의 최종 Nav3 진입 구조를 소비하며 설정 Nav2 목적지 래퍼는 추가하지 않습니다. 바탕 Composable은 같은 파일의 데코레이터만 호출하므로 private이고, 배경값은 앱 모듈이 소비합니다.검증 결과:
docs/qa/predictive-back.md5번 절차를 따릅니다.타임레터·마음의 기록의 기존 Nav2 화면은 이 공통 바탕의 적용 대상이 아니며, 잔여 결함은 #2149·#2150에서 추적합니다.
CI Test Plan
{ "androidTest": { "mode": "selected", "reason": "공통 Nav3 entry 데코레이터의 불투명 바탕이 설정·애프터노트·수신자·온보딩 로컬 스택에 적용됩니다. 최종 SettingNavHost 실제 진입 4건, MainActivity 로그인 후 홈 및 노트 탭 진입 1건, 애프터노트·수신자·온보딩 대표 3건을 API 34에서 선택 실행합니다. 실제 픽셀 바탕은 FeatureNavDisplayTest가 검증합니다.", "tests": [ { "path": "app/src/androidTest/java/com/afternote/afternote_fe/SettingImplementedCoverageAndroidTest.kt", "selector": "com.afternote.afternote_fe.SettingImplementedCoverageAndroidTest#settingNavHost_startWithRecipientRegistrationOpensRegisterFirstAndBackExitsHost", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/SettingImplementedCoverageAndroidTest.kt", "selector": "com.afternote.afternote_fe.SettingImplementedCoverageAndroidTest#settingNavHost_receiverManageListRowNavigatesToEditWithExactReceiverId", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/SettingImplementedCoverageAndroidTest.kt", "selector": "com.afternote.afternote_fe.SettingImplementedCoverageAndroidTest#settingNavHost_deliveryConditionReceiverSelectionPreservesExactReceiverId", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/SettingImplementedCoverageAndroidTest.kt", "selector": "com.afternote.afternote_fe.SettingImplementedCoverageAndroidTest#settingNavHost_withdrawGuideCancelThenAgreementConfirmPreservesBoundary", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/AppAndReceiverCompletionAndroidTest.kt", "selector": "com.afternote.afternote_fe.AppAndReceiverCompletionAndroidTest#invalidCredentials_correctedPasswordThenRetry_entersHomeWithoutReportingUserError", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/AfternoteAuthorExtendedAndroidTest.kt", "selector": "com.afternote.afternote_fe.AfternoteAuthorExtendedAndroidTest#home_loadingErrorRetrySuccess_filterAndRoutesStayConnectedToRepository", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/ReceiverAdvancedAndroidTest.kt", "selector": "com.afternote.afternote_fe.ReceiverAdvancedAndroidTest#receivedDetail_failureThenRetry_showsRecoveredDetailAndCallsSameIdTwice", "device": "api34" }, { "path": "app/src/androidTest/java/com/afternote/afternote_fe/AppOnboardingCanaryTest.kt", "selector": "com.afternote.afternote_fe.AppOnboardingCanaryTest#coldStartWithoutSession_opensLoginFromWelcome", "device": "api34" } ] } }